Closed
Bug 1316692
Opened 8 years ago
Closed 8 years ago
Expose full talos results including replicates from PERFHERDER_DATA in perfherder API
Categories
(Tree Management :: Perfherder, defect)
Tree Management
Perfherder
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: Pike, Unassigned)
References
Details
Attachments
(1 file)
When evaluating performance questions, it's really useful to have access to the raw test results instead of just the median, for example.
Right now the only way to do that is to go through the resultset data, find the jobids, and then download the full log, and extract the line.
It'd be great to have a cheaper and faster way to get to that.
Comment hidden (mozreview-request) |
Comment 2•8 years ago
|
||
mozreview-review |
Comment on attachment 8819310 [details]
Bug 1316692 - Upload talos results as json artifact;
https://reviewboard.mozilla.org/r/99134/#review99426
::: testing/mozharness/mozharness/mozilla/testing/talos.py:417
(Diff revision 1)
> except:
> self.exception("Error while validating PERFHERDER_DATA")
> parser.update_worst_log_and_tbpl_levels(WARNING, TBPL_WARNING)
>
> + def _artifact_perf_data(self, dest):
> + src = os.path.join(self.query_abs_dirs()['abs_work_dir'], 'local.json')
does local.json get produced all the time?
::: testing/mozharness/mozharness/mozilla/testing/talos.py:421
(Diff revision 1)
> + def _artifact_perf_data(self, dest):
> + src = os.path.join(self.query_abs_dirs()['abs_work_dir'], 'local.json')
> + try:
> + shutil.copyfile(src, dest)
> + except:
> + self.exception("Error while copyig local.json results file")
nit: s/copyig/copying/
also: please print out the src and dest values here in case we need to debug more info.
::: testing/mozharness/mozharness/mozilla/testing/talos.py:422
(Diff revision 1)
> + src = os.path.join(self.query_abs_dirs()['abs_work_dir'], 'local.json')
> + try:
> + shutil.copyfile(src, dest)
> + except:
> + self.exception("Error while copyig local.json results file")
> + parser.update_worst_log_and_tbpl_levels(WARNING, TBPL_WARNING)
will we want to turn a job orange for this? I think so as we will find issues here.
Attachment #8819310 -
Flags: review?(jmaher) → review-
Comment 3•8 years ago
|
||
mozreview-review-reply |
Comment on attachment 8819310 [details]
Bug 1316692 - Upload talos results as json artifact;
https://reviewboard.mozilla.org/r/99134/#review99426
> does local.json get produced all the time?
Yes, as long as sps profiling is not on:
https://dxr.mozilla.org/mozilla-central/source/testing/talos/talos/run_tests.py#172
> nit: s/copyig/copying/
> also: please print out the src and dest values here in case we need to debug more info.
ok, good call
> will we want to turn a job orange for this? I think so as we will find issues here.
ok, thanks
Comment hidden (mozreview-request) |
Comment 5•8 years ago
|
||
mozreview-review |
Comment on attachment 8819310 [details]
Bug 1316692 - Upload talos results as json artifact;
https://reviewboard.mozilla.org/r/99134/#review99444
thanks you
Attachment #8819310 -
Flags: review?(jmaher) → review+
Pushed by rwood@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/bcd5a036290c
Upload talos results as json artifact; r=jmaher
Comment 7•8 years ago
|
||
bugherder |
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•