Closed
Bug 1317296
Opened 8 years ago
Closed 8 years ago
Intermittent histogram has expected content - [888,157,754] deepEqual [0,0,0,0,0,0] - JS frame :: chrome://mochitests/content/browser/browser/components/search/test/browser_aboutSearchReset.js :: checkTelemetryRecords :: line 26
Categories
(Toolkit :: Telemetry, defect)
Toolkit
Telemetry
Tracking
()
RESOLVED
FIXED
mozilla53
Tracking | Status | |
---|---|---|
firefox50 | --- | unaffected |
firefox51 | --- | unaffected |
firefox52 | --- | unaffected |
firefox53 | --- | fixed |
People
(Reporter: intermittent-bug-filer, Assigned: florian)
References
Details
(Keywords: intermittent-failure)
Attachments
(1 file)
(deleted),
patch
|
benjamin
:
review+
|
Details | Diff | Splinter Review |
Comment 1•8 years ago
|
||
i guess this something for you guys
Flags: needinfo?(gfritzsche)
Flags: needinfo?(alessio.placitelli)
Comment 2•8 years ago
|
||
actually now that we merge day this expired "expires_in_version": "53",
florian can you fix this asap since this is hitting m-c
Flags: needinfo?(gfritzsche)
Flags: needinfo?(florian)
Flags: needinfo?(alessio.placitelli)
Comment 3•8 years ago
|
||
(In reply to Carsten Book [:Tomcat] from comment #2)
> actually now that we merge day this expired "expires_in_version": "53",
>
> florian can you fix this asap since this is hitting m-c
btw let me when you have a patch etc and i can direct land this on m-c
Assignee | ||
Comment 5•8 years ago
|
||
Shipping the search reset feature has been delayed as we want to test it with a Shield experiment before deploying to all the release population, so we very much need this probe for another couple months. Bumping to 57 to add 4 releases / about 6 months.
I find it strange that the test fails with the histogram containing random values, rather than an exception saying the histogram doesn't exist, but I verified locally that bumping the version limit on the probe is all it takes to fix this.
Attachment #8810473 -
Flags: review?(benjamin)
Assignee | ||
Updated•8 years ago
|
Assignee: nobody → florian
Status: NEW → ASSIGNED
Updated•8 years ago
|
Attachment #8810473 -
Flags: review?(benjamin) → review+
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/mozilla-central/rev/71fd23fa0803
Keep the SEARCH_RESET_RESULT Telemetry probe until Firefox 57. r=bsmedberg
Updated•8 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
status-firefox53:
--- → fixed
Flags: needinfo?(florian)
Resolution: --- → FIXED
Target Milestone: --- → mozilla53
Comment 7•8 years ago
|
||
> I find it strange that the test fails with the histogram containing random
> values, rather than an exception saying the histogram doesn't exist, but I
Should a followup bug be filed on that issue?
Assignee | ||
Comment 8•8 years ago
|
||
(In reply to Bill Gianopoulos [:WG9s] from comment #7)
> > I find it strange that the test fails with the histogram containing random
> > values, rather than an exception saying the histogram doesn't exist, but I
>
> Should a followup bug be filed on that issue?
Is it the expected behavior that reading data from an expired histogram using Services.telemetry.getHistogramById(name).snapshot() returns odd values? I would have expected that to throw an exception.
Hopefully Georg knows.
Flags: needinfo?(gfritzsche)
Comment 9•8 years ago
|
||
There is a bug tree at bug 1311100 for addressing semantic weirdness of the Telemetry APIs in exceptional cases. This one in particular isn't called out, so I'll wait for :gfritzsche's ni? then file a bug :)
Comment 10•8 years ago
|
||
> Is it the expected behavior that reading data from an expired histogram
> using Services.telemetry.getHistogramById(name).snapshot() returns odd
> values? I would have expected that to throw an exception.
As opposed to even values? (Sorry I could not resist) ;-)
Comment 11•8 years ago
|
||
(In reply to Chris H-C :chutten from comment #9)
> There is a bug tree at bug 1311100 for addressing semantic weirdness of the
> Telemetry APIs in exceptional cases. This one in particular isn't called
> out, so I'll wait for :gfritzsche's ni? then file a bug :)
This is a quirk of the histogram expiry implementation. (all expired histograms are treated as the same one histogram).
I filed bug 1317702 about this.
Flags: needinfo?(gfritzsche)
Updated•8 years ago
|
status-firefox50:
--- → unaffected
status-firefox51:
--- → unaffected
status-firefox52:
--- → unaffected
Comment hidden (Intermittent Failures Robot) |
You need to log in
before you can comment on or make changes to this bug.
Description
•