Closed
Bug 1383770
Opened 7 years ago
Closed 7 years ago
browser_aboutSearchReset.js is going to permafail when the Gecko version number is bumped to 57 due to the SEARCH_RESET_RESULT telemetry probe expiration
Categories
(Firefox :: Search, defect)
Firefox
Search
Tracking
()
RESOLVED
FIXED
Firefox 56
Tracking | Status | |
---|---|---|
firefox56 | --- | fixed |
People
(Reporter: RyanVM, Assigned: florian)
References
Details
Attachments
(1 file)
(deleted),
patch
|
benjamin
:
review+
|
Details | Diff | Splinter Review |
[Tracking Requested - why for this release]: Permafailing test when the Gecko version is bumped to 57 on August 2.
+++ This bug was initially created as a clone of Bug #1317296 +++
https://treeherder.mozilla.org/logviewer.html#?job_id=116981153&repo=try
TEST-UNEXPECTED-FAIL | browser/components/search/test/browser_aboutSearchReset.js | histogram has expected content - [846,633,580] deepEqual [0,0,0,0,0,0] - JS frame :: chrome://mochitests/content/browser/browser/components/search/test/browser_aboutSearchReset.js :: checkTelemetryRecords :: line 26
TEST-UNEXPECTED-FAIL | browser/components/search/test/browser_aboutSearchReset.js | histogram has expected content - [5,39,2] deepEqual [0,1,0,0,0,0] - JS frame :: chrome://mochitests/content/browser/browser/components/search/test/browser_aboutSearchReset.js :: checkTelemetryRecords :: line 26
TEST-UNEXPECTED-FAIL | browser/components/search/test/browser_aboutSearchReset.js | histogram has expected content - [3,29,1] deepEqual [1,0,0,0,0,0] - JS frame :: chrome://mochitests/content/browser/browser/components/search/test/browser_aboutSearchReset.js :: checkTelemetryRecords :: line 26
TEST-UNEXPECTED-FAIL | browser/components/search/test/browser_aboutSearchReset.js | histogram has expected content - [7,966,3] deepEqual [0,0,0,0,1,0] - JS frame :: chrome://mochitests/content/browser/browser/components/search/test/browser_aboutSearchReset.js :: checkTelemetryRecords :: line 26
TEST-UNEXPECTED-FAIL | browser/components/search/test/browser_aboutSearchReset.js | histogram has expected content - [63,47,2] deepEqual [0,0,0,1,0,0] - JS frame :: chrome://mochitests/content/browser/browser/components/search/test/browser_aboutSearchReset.js :: checkTelemetryRecords :: line 26
Flags: needinfo?(florian)
Assignee | ||
Comment 1•7 years ago
|
||
The search reset feature still hasn't shipped to release users.
The current plan is to roll it out on 55 or 56 for only the affected users, using Shield.
We'll definitely need this probe in 55 and 56, but I don't think it would be a good idea to remove the probe from central before we have analyzed the results, so let's bump it by another 3 releases.
Attachment #8889474 -
Flags: review?(benjamin)
Assignee | ||
Updated•7 years ago
|
Assignee: nobody → florian
Status: NEW → ASSIGNED
Comment 2•7 years ago
|
||
Comment on attachment 8889474 [details] [diff] [review]
Keep the SEARCH_RESET_RESULT Telemetry probe until Firefox 60,
data-r=me
Attachment #8889474 -
Flags: review?(benjamin) → review+
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/fbc19eff958c
Keep the SEARCH_RESET_RESULT Telemetry probe until Firefox 60. r=bsmedberg
Comment 4•7 years ago
|
||
bugherder |
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox56:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 56
Assignee | ||
Updated•7 years ago
|
Flags: needinfo?(florian)
Since this is fixed, no need to track it for 57.
tracking-firefox57:
? → ---
You need to log in
before you can comment on or make changes to this bug.
Description
•