Closed
Bug 1317976
Opened 8 years ago
Closed 8 years ago
enable performance counters for taskcluster windows builds
Categories
(Release Engineering :: General, defect)
Release Engineering
General
Tracking
(firefox53 fixed)
RESOLVED
FIXED
Tracking | Status | |
---|---|---|
firefox53 | --- | fixed |
People
(Reporter: grenade, Assigned: grenade)
References
Details
Attachments
(1 file)
so that we can generate reports like this one (for bb win builds): https://treeherder.mozilla.org/perf.html#/graphs?series=%5Bmozilla-inbound,4fbfc3c875f4dd781769fd461689a1cbb88c704f,1,2%5D&series=%5Bmozilla-inbound,da9415dda623287ef4a2b0d749e9a773d606e1d5,1,2%5D&series=%5Bmozilla-inbound,592b8602a8902b60c93afd6d953ad3a629cc895c,1,2%5D
from irc:
15:17 W<wlach> grenade|afk: should be pretty simple, you just need to add a line called PERFHERDER_DATA to the logfile for the job with information on timings. grep for that string in m-c and you should find examples (you should probably model after what we do for other builds)
Comment hidden (mozreview-request) |
Comment 2•8 years ago
|
||
Comment on attachment 8814161 [details]
Bug 1317976 - enable generate-build-stats on tc win builds
I don't think I'm the right person to review this, there isn't anything perfherder-specific here. Redirecting to :ted (I'm not sure if he's the right person either, but at least he might know...)
Flags: needinfo?(ted)
Updated•8 years ago
|
Attachment #8814161 -
Flags: review?(wlachance)
Assignee | ||
Comment 3•8 years ago
|
||
Comment on attachment 8814161 [details]
Bug 1317976 - enable generate-build-stats on tc win builds
gps: if possible could you review this patch to enable performance counters on tc windows builds?
Flags: needinfo?(ted)
Attachment #8814161 -
Flags: review?(gps)
Comment 4•8 years ago
|
||
mozreview-review |
Comment on attachment 8814161 [details]
Bug 1317976 - enable generate-build-stats on tc win builds
https://reviewboard.mozilla.org/r/95432/#review97486
This looks good, thanks for fixing it! (I wish I'd had these stats enabled for comparing sccache build times.)
::: testing/mozharness/mozharness/mozilla/building/buildbase.py:1931
(Diff revision 1)
> packageName = name
> break
> + # if we are not using MOZ_SIMPLE_PACKAGE_NAME, check for the
> + # default package naming convention
> + name = 'firefox-{}.en-US.{}.{}'.format(
> + self.get_firefox_version(), c.get('platform'), ext)
Minor issue, but maybe hoist the `get_firefox_version()` call out of the loop?
Attachment #8814161 -
Flags: review+
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Assignee | ||
Comment 7•8 years ago
|
||
implemented change to move `get_firefox_version()` out of the loop and rebased against tip (some filenames had changed).
Keywords: checkin-needed
Comment 8•8 years ago
|
||
mozreview-review |
Comment on attachment 8814161 [details]
Bug 1317976 - enable generate-build-stats on tc win builds
https://reviewboard.mozilla.org/r/95432/#review97552
Attachment #8814161 -
Flags: review+
Pushed by gszorc@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/6d2d2fdac6c7
enable generate-build-stats on tc win builds r=gps,ted
Keywords: checkin-needed
Comment 10•8 years ago
|
||
bugherder |
Updated•7 years ago
|
Component: General Automation → General
You need to log in
before you can comment on or make changes to this bug.
Description
•