Closed
Bug 1318037
Opened 8 years ago
Closed 8 years ago
[tcmigration-Tier2] adjust beetmoverworker/beetmoverscript to accommodate desktop and mobile l10n nightlies
Categories
(Release Engineering :: General, defect)
Release Engineering
General
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: mtabara, Assigned: mtabara)
References
Details
Attachments
(3 files)
(deleted),
text/x-github-pull-request
|
Callek
:
review+
mtabara
:
checked-in+
|
Details |
(deleted),
text/x-review-board-request
|
Callek
:
review+
mtabara
:
checked-in+
|
Details |
(deleted),
text/plain
|
mtabara
:
checked-in+
|
Details |
In bug 1313154 we added support in beetmoverscript and beetmoverworker to handle the transfer of the artifacts from unsigned/signed jobs to S3 locations for both mobile/desktop products, but single-locale'ed.
This is a tracking bug for all the l10n changes that we still need to address in beetmoverworker/beetmoverscript.
Assignee | ||
Updated•8 years ago
|
Summary: [tcmigration] adjust beetmoverworker/beetmoverscript to accommodate desktop and mobile l10n nightlies → [tcmigration-Tier2] adjust beetmoverworker/beetmoverscript to accommodate desktop and mobile l10n nightlies
Comment 1•8 years ago
|
||
###################
## Desktop L10n: ##
###################
(archive.m.o is nightly/latest-*-l10n/ where * == same as non-l10n)
(TC artifact path is public/build/{locale}/* where the * is named.)
--- UNSIGNED ---
TC Artifact Path ==> archive.m.o path
=====================================
langpack.xpi ==> {platform}/xpi/firefox-{version}.{locale}.langpack.xpi
--- SIGNED ---
TC Artifact Path ==> archive.m.o path
=====================================
target.complete.mar ==> firefox-{version}.locale.{platform}.complete.mar
\-- This one gets rewritten as the target binary in the balrog stuff.
target.tar.bz2 ==> firefox-{version}.locale.{platform}.tar.bz2
target.tar.bz2.asc ==> firefox-{version}.locale.{platform}.tar.bz2.asc
\-- This actually doesn't seem to upload the .asc presently, it should thus why its here.
###################
## Fennec L10n: ##
###################
(archive.m.o is nightly/latest-*-l10n/ where * == same as non-l10n)
(TC artifact path is public/build/{locale}/* where the * is named.)
--- UNSIGNED ---
TC Artifact Path ==> archive.m.o path
=====================================
-- NOTHING!!! --
--- SIGNED ---
TC Artifact Path ==> archive.m.o path
=====================================
target.apk ==> fennec-{version}.{locale}.{platform}.apk
Flags: needinfo?(mtabara)
Assignee | ||
Comment 2•8 years ago
|
||
(In reply to Justin Wood (:Callek) from comment #1)
> ###################
> ## Desktop L10n: ##
> ###################
>
> (archive.m.o is nightly/latest-*-l10n/ where * == same as non-l10n)
> (TC artifact path is public/build/{locale}/* where the * is named.)
>
> --- UNSIGNED ---
> TC Artifact Path ==> archive.m.o path
> =====================================
> langpack.xpi ==> {platform}/xpi/firefox-{version}.{locale}.langpack.xpi
>
Correct. I'll tweak the mapping accordingly.
>
> --- SIGNED ---
> TC Artifact Path ==> archive.m.o path
> =====================================
> target.complete.mar ==> firefox-{version}.locale.{platform}.complete.mar
> \-- This one gets rewritten as the target binary in the balrog stuff.
> target.tar.bz2 ==> firefox-{version}.locale.{platform}.tar.bz2
> target.tar.bz2.asc ==> firefox-{version}.locale.{platform}.tar.bz2.asc
> \-- This actually doesn't seem to upload the .asc presently, it should
> thus why its here.
>
Currently for single-locales there is:
update/target.complete.mar ==> firefox-{{ version }}.{{ locale }}.{{ platform }}.complete.mar
\-- its info gets dumped in the balrog manifest passed down to balrogworker
target.checksums ==> firefox-{{ version }}.{{ locale }}.{{ platform }}.checksums
target.checksums.asc ==> firefox-{{ version }}.{{ locale }}.{{ platform }}.checksums.asc
target.tar.bz2 ==> firefox-{{ version }}.{{ locale }}.{{ platform }}.tar.bz2
>
>
>
>
> ###################
> ## Fennec L10n: ##
> ###################
>
> (archive.m.o is nightly/latest-*-l10n/ where * == same as non-l10n)
> (TC artifact path is public/build/{locale}/* where the * is named.)
>
> --- UNSIGNED ---
> TC Artifact Path ==> archive.m.o path
> =====================================
> -- NOTHING!!! --
>
Correct.
>
> --- SIGNED ---
> TC Artifact Path ==> archive.m.o path
> =====================================
> target.apk ==> fennec-{version}.{locale}.{platform}.apk
Correct. We'll need to add the `checkscums` and `checksums.asc` too but as I taked to :aki, that's not blocking Tier-2, hence we'll address it before Tier-1.
Flags: needinfo?(mtabara)
Assignee | ||
Comment 3•8 years ago
|
||
Obs:We're currently having some errors in the desktop nightly graphs. Could be from patches we landed on Friday.
As soon as we fix those, if my understanding is right, we'd have:
> I stated if for Fennec but it's the same for Firefox
> let's just pick-up `de` locale for the sake of the example
> note the "is_locale_task" new var added to pass down the locale in beetmoverscript
1. one beetmover-nightly-de-android-api-15-nightly-1/opt
with payload
{
"maxRunTime": 600,
"upload_date": ...,
"update_manifest": false,
"is_locale_task": 'de',
"taskid_of_manifest": "<task_id_of_nightly-l10n-job containing `de` locale with balrogprops",
"taskid_to_beetmove": "<task_id_of_nightly-l10n-job containing `de` locale with balrogprops"
}
2. one beetmover-signing-de-android-api-15-nightly-1/opt
with payload
{
"maxRunTime": 600,
"upload_date": ...,
"update_manifest": true,
"is_locale_task": 'de',
"taskid_of_manifest": "<task_id_of_nightly-l10n-job containing `de` locale with balrogprops",
"taskid_to_beetmove": "<task_id_of_-signing-nightly-l10n-job containing `de` locale"
}
3. one balrog-beetmover-signing-de-android-api-15-nightly/opt
with payload
{
"signing_cert": "dep",
"parent_task_artifacts_url": "<task id of 2 from above>"
}
Of course, per each of these per platform.
Right?
Flags: needinfo?(bugspam.Callek)
Comment 4•8 years ago
|
||
(In reply to Mihai Tabara [:mtabara] ⌚️GMT from comment #3)
> Obs:We're currently having some errors in the desktop nightly graphs. Could
> be from patches we landed on Friday.
>
> As soon as we fix those, if my understanding is right, we'd have:
> > I stated if for Fennec but it's the same for Firefox
> > let's just pick-up `de` locale for the sake of the example
> > note the "is_locale_task" new var added to pass down the locale in beetmoverscript
I'd prefer no `is_locale_task` and just `locale` if possible, (but not too worried about it)
>
> 1. one beetmover-nightly-de-android-api-15-nightly-1/opt
>
> with payload
>
> {
> "maxRunTime": 600,
> "upload_date": ...,
> "update_manifest": false,
> "is_locale_task": 'de',
> "taskid_of_manifest": "<task_id_of_nightly-l10n-job containing `de` locale
> with balrogprops",
> "taskid_to_beetmove": "<task_id_of_nightly-l10n-job containing `de` locale
> with balrogprops"
> }
Indeed its probably easiest including this for android (though we don't need it there). Because we do need it for linux, so beetmover would do no actual moving for android.
> 2. one beetmover-signing-de-android-api-15-nightly-1/opt
>
> with payload
>
> {
> "maxRunTime": 600,
> "upload_date": ...,
> "update_manifest": true,
> "is_locale_task": 'de',
> "taskid_of_manifest": "<task_id_of_nightly-l10n-job containing `de` locale
> with balrogprops",
> "taskid_to_beetmove": "<task_id_of_-signing-nightly-l10n-job containing
> `de` locale"
> }
>
> 3. one balrog-beetmover-signing-de-android-api-15-nightly/opt
>
> with payload
>
> {
> "signing_cert": "dep",
> "parent_task_artifacts_url": "<task id of 2 from above>"
> }
>
> Of course, per each of these per platform.
> Right?
Yes.
Flags: needinfo?(bugspam.Callek) → needinfo?(mtabara)
Assignee | ||
Updated•8 years ago
|
Flags: needinfo?(mtabara)
Assignee | ||
Comment 5•8 years ago
|
||
Attachment #8813176 -
Flags: review?(bugspam.Callek)
Comment 6•8 years ago
|
||
Comment on attachment 8813176 [details]
Bug 1318037 - adjust beetmover to cope with l10n for both desktop and mobile. r=Callek
notes on PR
Attachment #8813176 -
Flags: review?(bugspam.Callek) → review+
Assignee | ||
Comment 7•8 years ago
|
||
Comment on attachment 8813176 [details]
Bug 1318037 - adjust beetmover to cope with l10n for both desktop and mobile. r=Callek
Squashed and merged - https://github.com/mozilla-releng/beetmoverscript/commit/d75bdd87b60d49049e4c5ae7cc6bab9fafad4075
Bumped a new beetmoverscript version too - https://github.com/mozilla-releng/beetmoverscript/commit/bf9ab5ee22f2e61f938dde52697d798c02976c00
Attachment #8813176 -
Flags: checked-in+
Comment hidden (mozreview-request) |
Comment 9•8 years ago
|
||
mozreview-review |
Comment on attachment 8813201 [details]
Bug 1318037 - tweak beetmoverworker to cope with l10n nightlies.
https://reviewboard.mozilla.org/r/94708/#review94926
Attachment #8813201 -
Flags: review?(bugspam.Callek) → review+
Assignee | ||
Comment 10•8 years ago
|
||
Comment on attachment 8813201 [details]
Bug 1318037 - tweak beetmoverworker to cope with l10n nightlies.
https://hg.mozilla.org/build/puppet/rev/b1af94d5dbaa
Attachment #8813201 -
Flags: checked-in+
Assignee | ||
Comment 11•8 years ago
|
||
Attachment #8813423 -
Flags: checked-in+
Comment 12•8 years ago
|
||
I believe this is done. Let's comment+reopen if that's not accurate.
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Updated•7 years ago
|
Component: General Automation → General
You need to log in
before you can comment on or make changes to this bug.
Description
•