Closed
Bug 1320453
Opened 8 years ago
Closed 8 years ago
remove nsISupportsArray from SM test test_0_bug510634.xul
Categories
(SeaMonkey :: Bookmarks & History, defect)
SeaMonkey
Bookmarks & History
Tracking
(Not tracked)
RESOLVED
FIXED
seamonkey2.50
People
(Reporter: aceman, Assigned: aceman)
References
Details
Attachments
(1 file)
|
(deleted),
patch
|
philip.chee
:
review+
|
Details | Diff | Splinter Review |
I think tree.view.getCellProperties() does not return a nsISupportsArray for a long time. If the test_0_bug510634.xul uses the tree implementation at https://dxr.mozilla.org/comm-central/rev/4f8486123b817d6b18bf2684a0f7e5facf725ce6/suite/common/places/treeView.js#1106 then getCellProperties returns a string with space separated values as all the other tree implementations.
I think this is what needs to be done, but I can't test it in SM. I wonder if the test is even enabled in the test suite and was passing till today. Please try it in Seamonkey.
Attachment #8814558 -
Flags: review?(philip.chee)
Attachment #8814558 -
Flags: review?(iann_bugzilla)
|
||
Comment 2•8 years ago
|
||
Comment on attachment 8814558 [details] [diff] [review] patch rs=me
Attachment #8814558 -
Flags: review?(philip.chee) → review+
https://hg.mozilla.org/comm-central/rev/707ecc6cda8411109910ebdd8f2fe551009dbb79
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → seamonkey2.50
Attachment #8814558 -
Flags: review?(iann_bugzilla)
You need to log in
before you can comment on or make changes to this bug.
Description
•