Nick Kreeger Reporter
	Description • 17 years ago

Since the |nsISupportsArray| class is now obsolete, we should switch over and start using the |nsIArray| class.

	:aceman Assignee
	Comment 1 • 8 years ago

https://developer.mozilla.org/en-US/docs/Mozilla/Tech/XPCOM/Guide/Arrays#nsISupportsArray

	:aceman Assignee
	Comment 2 • 7 years ago

Once the blocking bugs are done, we can remove the nsISupportsArray from iteratorUtils:
base/util/iteratorUtils.jsm: *   nsISupportsArray
base/util/iteratorUtils.jsm:  // Try an nsISupportsArray.
base/util/iteratorUtils.jsm:  if (aEnum instanceof Ci.nsISupportsArray) {
base/util/iteratorUtils.jsm:  if (aInterface.equals(Ci.nsISupportsArray)) {
base/util/iteratorUtils.jsm:    Deprecated.warning("nsISupportsArray object is deprecated, avoid creating new ones.",
base/util/iteratorUtils.jsm:                                  .createInstance(Ci.nsISupportsArray);
base/test/unit/test_iteratorUtils.js:  let nsISupportsArray = iteratorUtils.toXPCOMArray(nsIArray, Ci.nsISupportsArray);
base/test/unit/test_iteratorUtils.js:  do_check_eq(nsISupportsArray.Count(), 5);
base/test/unit/test_iteratorUtils.js:  for (let val in iteratorUtils.fixIterator(nsISupportsArray)) {

This support was only kept for addon-compatibility but is no longer used in base TB. If m-c removes support for nsISupportsArray we have no choice than just to remove it from here too as the Ci.nsISupportsArray will probably throw.

	:aceman Assignee
	Comment 3 • 7 years ago

m-c has removed nsISupportsArray now so we must do this.

	Jorg K (CEST = GMT+2)
	Comment 4 • 7 years ago

Comment on attachment 8845188 [details] [diff] [review]
patch

Fine by me upon visual inspection ;-)

	Jorg K (CEST = GMT+2)
	Comment 5 • 7 years ago

https://hg.mozilla.org/comm-central/rev/eadb929f668904e88c5dccfdb220b67f9256cc9c
I guess we're done here.

	:aceman Assignee
	Comment 6 • 7 years ago

Thanks.

	:aceman Assignee
	Comment 7 • 7 years ago

Sorry, missed nsIEnumerator going away too. We just mention it in a comment.

	Jorg K (CEST = GMT+2)
	Comment 8 • 7 years ago

Comment on attachment 8845271 [details] [diff] [review]
patch 2

Sure, thanks.

	Jorg K (CEST = GMT+2)
	Comment 9 • 7 years ago

https://hg.mozilla.org/comm-central/rev/eadb929f668904e88c5dccfdb220b67f9256cc9c (comment #5)
https://hg.mozilla.org/comm-central/rev/64efa461aeb0ba7b5a460395d7dcbde56beeafdc