Investigate removing devtools/shared/css/generated/properties-db.js
Categories
(Firefox Build System :: General, defect)
Tracking
(firefox53 affected)
Tracking | Status | |
---|---|---|
firefox53 | --- | affected |
People
(Reporter: MatsPalmgren_bugz, Assigned: ochameau)
References
Details
Attachments
(1 file)
(deleted),
text/x-phabricator-request
|
Details |
Comment 1•8 years ago
|
||
Reporter | ||
Comment 2•8 years ago
|
||
Comment 3•8 years ago
|
||
Reporter | ||
Comment 4•8 years ago
|
||
Reporter | ||
Comment 5•8 years ago
|
||
Reporter | ||
Comment 6•8 years ago
|
||
Comment 7•8 years ago
|
||
Reporter | ||
Comment 8•8 years ago
|
||
Comment 10•8 years ago
|
||
Comment 11•8 years ago
|
||
Comment 12•8 years ago
|
||
Comment 13•8 years ago
|
||
Updated•7 years ago
|
Comment 14•3 years ago
|
||
Is there any reason we can't generate this database in the object directory?
This is the single biggest backout cause when touching the style system :)
Comment 15•3 years ago
|
||
It needs a fully built binary to generate the list for the reasons listed above. It might be able to be generated if there is a point where you can run the binary to query it.
At this point it would be useful to evaluate whether it can be removed, since this was part of the devtools de-chromifying requirements whenever DevTools failed to move to GitHub. I don't really have the requirements in my head, but it could be that it could be removed. It's also one of the bigger files shipped to end users in the packaged build. If I recall, this call is mostly to get a list of properties from the debuggee.
Updated•2 years ago
|
Comment 16•2 years ago
|
||
As Greg said, this was done for an unsuccessful project, and we could probably remove it entirely
Updated•2 years ago
|
Updated•2 years ago
|
Assignee | ||
Comment 17•1 year ago
|
||
It looks like this was useless in today's codebase.
This was only used by tests codepath, where we can use data queried directly from the runtime.
I added an assertion to see if we miss cssProperties
and try looks green:
https://treeherder.mozilla.org/jobs?repo=try&revision=fc32fd0b9e1f10db2581501bb3bf3038253d05ce
Also tested remote debugging without seeing anything wrong.
Assignee | ||
Comment 18•1 year ago
|
||
This wasn't really used anymore.
We are fetching the database from the server runtime in order to support
remote debugging correctly, where frontend CSS may be different from debuggee CSS.
Updated•1 year ago
|
Description
•