Closed
Bug 1322269
Opened 8 years ago
Closed 7 years ago
Can't login/signin if treeherder url contains some parameters
Categories
(Tree Management :: Treeherder, defect)
Tree Management
Treeherder
Tracking
(Not tracked)
RESOLVED
WORKSFORME
People
(Reporter: aryx, Assigned: camd, Mentored)
References
Details
(Whiteboard: [lang=py])
Reproduced with Firefox 50.0.2 + 53.0a1
If the treeherder url contains more parameters than the tree, sign in with email fails. The sign in page shows the access token (but e.g. no Grant button for prototype).
Steps to reproduce:
1. Open a profile where you aren't signed into Treeherder or log out.
2. Visit https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&filter-resultStatus=testfailed&filter-resultStatus=busted&filter-resultStatus=exception&filter-resultStatus=retry&filter-resultStatus=usercancel&filter-resultStatus=runnable&selectedJob=40327564
3. Click the login button on the top right.
4. Choose signin with email.
5. Enter credentials.
Actual result:
Signin tab doesn't close, Treeherder shows still as anonymous.
Expected result:
Signin works.
6. Go to https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound
7. Sign in.
Actual and expected result:
Sign in works.
This also hit me last week on https://treeherder-prototype.herokuapp.com/#/jobs?repo=mozilla-inbound&filter-resultStatus=testfailed&filter-resultStatus=busted&filter-resultStatus=exception&filter-resultStatus=retry&filter-resultStatus=usercancel&filter-resultStatus=runnable&fromchange=40e828d5ac43ca22a27c3adea2b01ffa4e062dec&selectedJob=39441908
Assignee | ||
Comment 1•8 years ago
|
||
OK, dang. This is my bug alright. Taking this now and I'll work on it as soon as I can.
Assignee: nobody → cdawson
Updated•8 years ago
|
Flags: needinfo?(cdawson)
Comment 2•8 years ago
|
||
I'm presuming we should just use the domain rather than domain/path/querystring for the URL signed?
Assignee | ||
Updated•7 years ago
|
Mentor: cdawson
Whiteboard: [lang=py]
Comment 3•7 years ago
|
||
I would be interested in pursuing this bug if it is still available.
Assignee | ||
Comment 4•7 years ago
|
||
Nathaniel: That would be great! Please have at it! Do you feel you know where to start? Or do you need any info before you get going? Please let me know, I'm happy to help. :)
Comment 5•7 years ago
|
||
Using the URL pointing to the prototype server on Heroku I followed the procedure specified above and was able to login just fine, is it an intermittent issue of some sort?
Reporter | ||
Comment 6•7 years ago
|
||
No, the issue has been resolved.
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → WORKSFORME
You need to log in
before you can comment on or make changes to this bug.
Description
•