Closed Bug 1322389 Opened 8 years ago Closed 8 years ago

about:profiles doesn't looks well on RTL builds

Categories

(Toolkit :: Startup and Profile System, defect, P5)

Product:
Toolkit
Component:
Startup and Profile System
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla53
Tracking Flags:
Tracking Status
firefox53 --- fixed

People

(Reporter: tomer, Assigned: itiel_yn8)

References

(
URL
)

Details

(Keywords: rtl, Whiteboard: good first bug)

Attachments

(1 file, 1 obsolete file)

Bug 1322389 about:profiles doesn't looks well on RTL builds
(deleted), text/x-review-board-request
ehsan.akhgari
: review+
Details
The about:profile page is part of a new Profile Manager UI. This page is currently localized on Nightly, but doesn't display well because the page lacks dir=rtl.
Summary: about:profiles doesn't have looks well on RTL builds → about:profiles doesn't looks well on RTL builds
Assignee: nobody → itiel_yn8
Attached patch patch (obsolete) (deleted) — — Splinter Review
Comment on attachment 8817246 [details] [diff] [review] patch Great work, ItielMaN. I'll transform this change into a commit.
Attachment #8817246 - Attachment description: 1298688.patch → patch
Attachment #8817246 - Attachment is obsolete: true
Priority: -- → P5
Attachment #8817253 - Flags: review?(ehsan)
Comment on attachment 8817253 [details] Bug 1322389 about:profiles doesn't looks well on RTL builds https://reviewboard.mozilla.org/r/97624/#review99934 Thanks for the fix!
Attachment #8817253 - Flags: review?(ehsan) → review+
Status: NEW → ASSIGNED
Keywords: checkin-needed
Pushed by ihsiao@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/8fe4d9b603a0 about:profiles doesn't looks well on RTL builds r=Ehsan
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/8fe4d9b603a0
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
status-firefox53: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla53
Depends on: 1329433
QA Whiteboard: [good first verify]
I have reproduced this bug with Nightly 53.0a1 (2016-12-07) (64 Bit) (Ar) on WIndows 7, 64 Bit! This bug's fix is verified with latest Beta(Ar)! Build ID : 20170403072723 User Agent : Mozilla/5.0 (Windows NT 6.1; Win64; x64; rv:53.0) Gecko/20100101 Firefox/53.0 [bugday-20170412]
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: