Closed
Bug 1329433
Opened 8 years ago
Closed 8 years ago
Improve about:profiles for RTL support
Categories
(Toolkit :: Startup and Profile System, defect)
Toolkit
Startup and Profile System
Tracking
()
RESOLVED
FIXED
mozilla53
Tracking | Status | |
---|---|---|
firefox53 | --- | fixed |
People
(Reporter: itiel_yn8, Assigned: tomer)
References
()
Details
(Keywords: rtl)
Attachments
(2 files)
In bug 1322389 we changed about:profiles so it would support RTL, but paths shown in it should always appear as LTR, even if they contain RTL characters.
Comment hidden (mozreview-request) |
Assignee | ||
Comment 2•8 years ago
|
||
mozreview-review |
Comment on attachment 8824703 [details]
Bug 1329433 - Improve about:profiles for RTL support
https://reviewboard.mozilla.org/r/103062/#review103640
::: toolkit/themes/shared/aboutProfiles.css:51
(Diff revision 1)
> width: 0px;
> }
>
> td {
> border-color: var(--in-content-table-border-dark-color);
> + unicode-bidi: plaintext;
This is a quick dirty fix, as the page doesn't provide different classes to cells with paths than other fields (such as the boolean value of "Is default profile". This should be enough, although not the prettiest fix. In case the page will get major redesign in the future, I guess we will have better solutions.
Assignee | ||
Updated•8 years ago
|
Assignee: nobody → tomer.moz.bugs
Status: NEW → ASSIGNED
Comment 3•8 years ago
|
||
mozreview-review |
Comment on attachment 8824703 [details]
Bug 1329433 - Improve about:profiles for RTL support
https://reviewboard.mozilla.org/r/103064/#review104102
::: toolkit/themes/shared/aboutProfiles.css:51
(Diff revision 1)
> width: 0px;
> }
>
> td {
> border-color: var(--in-content-table-border-dark-color);
> + unicode-bidi: plaintext;
Can you please add some comment here explaining what this is used for? Thanks!
Attachment #8824703 -
Flags: review?(ehsan) → review+
Comment hidden (mozreview-request) |
Assignee | ||
Updated•8 years ago
|
Keywords: checkin-needed
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/01050a98e53e
Improve about:profiles for RTL support r=Ehsan
Keywords: checkin-needed
Comment 6•8 years ago
|
||
bugherder |
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
status-firefox53:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla53
You need to log in
before you can comment on or make changes to this bug.
Description
•