Closed
Bug 1323494
Opened 8 years ago
Closed 6 years ago
Port notification (doorhanger) changes to SeaMonkey from Bug 1282768 and Bug 1267604 and maybe others
Categories
(SeaMonkey :: General, defect)
Tracking
(seamonkey2.49esr unaffected, seamonkey2.60 fixed, seamonkey2.53 fixed, seamonkey2.57esr fixed)
RESOLVED
FIXED
seamonkey2.60
Tracking | Status | |
---|---|---|
seamonkey2.49esr | --- | unaffected |
seamonkey2.60 | --- | fixed |
seamonkey2.53 | --- | fixed |
seamonkey2.57esr | --- | fixed |
People
(Reporter: philip.chee, Assigned: frg)
References
(Blocks 2 open bugs)
Details
Attachments
(1 file, 3 obsolete files)
(deleted),
patch
|
iannbugzilla
:
review+
iannbugzilla
:
approval-comm-esr60+
|
Details | Diff | Splinter Review |
Spin off from Bug 1320442.
(In reply to Frank-Rainer Grahl from Bug 1320442 comment #4)
>>> We should also find out where the toolkit "Not Now" string went since
>>> &closeNotificationItem.label; doesn't seem to exist in mozilla-central any more.
> Good catch. I didn't notice this one. It was removed in Bug 1282768. I think
> Bug 1267604 mentioned there is why the add-on notifications now look so ugly.
Reporter | ||
Updated•8 years ago
|
Summary: Port notification (doorhanger) changes to SeaMonkey from port Bug 1282768 and Bug 1267604 → Port notification (doorhanger) changes to SeaMonkey from Bug 1282768 and Bug 1267604 and maybe others
Assignee | ||
Updated•8 years ago
|
Blocks: 2.50BulkMalfunctions
Comment 2•8 years ago
|
||
Error console tells me that there are a bunch of css var's that we don't know about. I haven't investigated it in detail, but it looks like there are var's that exists in toolkit/themes/shared/popupnotification.inc.css, but defined in the
browser/themes/*/browser.css files...
Assignee | ||
Updated•8 years ago
|
Blocks: 2.51BulkMalfunctions
Assignee | ||
Updated•8 years ago
|
Blocks: 2.52BulkMalfunctions
Assignee | ||
Comment 3•8 years ago
|
||
Just an experiment to switch the affected notifications over to the standard in toolkit. Also includes a shot at the new persistent-storage notification added in bug 1309123. Mostly works but needs styling, cleanup, website patch for text url (explanation to the user) and so on...
One problem: Unlike Fx notifications will not show up again in this session if you dismiss with "not now".
Assignee | ||
Updated•7 years ago
|
Blocks: 2.53BulkMalfunctions
Assignee | ||
Updated•7 years ago
|
Blocks: 2.55BulkMalfunctions
Assignee | ||
Updated•7 years ago
|
Blocks: 2.56BulkMalfunctions
Assignee | ||
Updated•7 years ago
|
Blocks: 2.57BulkMalfunctions
Assignee | ||
Comment 4•6 years ago
|
||
The imho last big bug in 2.53 so lets see if I can fix it.
Assignee: nobody → frgrahl
Status: NEW → ASSIGNED
Assignee | ||
Comment 5•6 years ago
|
||
persistent storage prompt came as a goodie. Was unable to test this on on 56 / 2.53. Can separate or remove this.
Geolocation prompt and web push prompt now work as expected and also in a private window.
Tested with
https://html5demos.com/geo/
http://www.bennish.net/web-notifications.html
No special styling done but both Classic and Modern display ok. Storage icon is the Fx one and bland svg meehh as usual. As stated unable to test.
I am not sure if there are actually prompts for geolocation and web notifications outside of the browser and without displaying a doorhanger possible. This would probably fail now but if any I could only think of feeds sites view which might do this. And TB does not have these either. Sidebar?
This could use a follow-up for other permissions prompts and proper styling in classic.
Attachment #8865859 -
Attachment is obsolete: true
Assignee | ||
Comment 6•6 years ago
|
||
Last one had a typo.
As stated let me know if I should separate or take out the storage permission prompt.
I didn't add new learnmore urls. The Mozilla ones are not suitable for SeaMonkey and we don't have any on the project website. Maybe another follow-up bug?
Attachment #8999449 -
Attachment is obsolete: true
Attachment #8999450 -
Flags: review?(iann_bugzilla)
Attachment #8999450 -
Flags: approval-comm-esr60?
Assignee | ||
Comment 7•6 years ago
|
||
Overlooked a minor error in the css.
Attachment #8999450 -
Attachment is obsolete: true
Attachment #8999450 -
Flags: review?(iann_bugzilla)
Attachment #8999450 -
Flags: approval-comm-esr60?
Attachment #8999453 -
Flags: review?(iann_bugzilla)
Attachment #8999453 -
Flags: approval-comm-esr60?
Comment on attachment 8999453 [details] [diff] [review]
1323494-notifications-257.patch
r/a=me
Yes, we will need some follow-up bugs for other prompts, improved styling and learn more links.
Attachment #8999453 -
Flags: review?(iann_bugzilla)
Attachment #8999453 -
Flags: review+
Attachment #8999453 -
Flags: approval-comm-esr60?
Attachment #8999453 -
Flags: approval-comm-esr60+
Pushed by frgrahl@gmx.net:
https://hg.mozilla.org/comm-central/rev/fce1e8896889
Switch gelocation and other permissions to Gecko notification prompt. r=IanN
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Assignee | ||
Comment 10•6 years ago
|
||
status-seamonkey2.53:
--- → affected
status-seamonkey2.57esr:
--- → fixed
status-seamonkey2.60:
--- → fixed
Target Milestone: --- → seamonkey2.60
Assignee | ||
Comment 11•6 years ago
|
||
Sorry wrong esr60 changeset in previous comment:
https://hg.mozilla.org/releases/comm-esr60/rev/db0e661b1e6ce2a2f44d1133b9d7e013708a65b6
Assignee | ||
Updated•4 years ago
|
You need to log in
before you can comment on or make changes to this bug.
Description
•