Comment on attachment 8819707 [details] [diff] [review] Port the muse-use check to the clang-tidy compatible framework Review of attachment 8819707 [details] [diff] [review]: ----------------------------------------------------------------- s/muse-use/must-use ::: build/clang-plugin/MustUseChecker.cpp @@ +20,5 @@ > +} > + > +void MustUseChecker::check( > + const MatchFinder::MatchResult &Result) { > + if (auto SC = Result.Nodes.getNodeAs<SwitchCase>("switchcase")) { I wonder whether or not this would be more efficient as: auto S = Result.Nodes.getNodeAs<Stmt>("stmt"); if (auto SC = dyn_cast<SwitchCase>(S)) { ...} where there is only one matcher in the earlier case, which always binds the stmt matched to "stmt". I think that this setup is probably cleaner though, so I'd say just stick with this.

Comment on attachment 8819707 [details] [diff] [review] Port the muse-use check to the clang-tidy compatible framework Review of attachment 8819707 [details] [diff] [review]: ----------------------------------------------------------------- ::: build/clang-plugin/CustomTypeAnnotation.cpp @@ +18,4 @@ > CustomTypeAnnotation NonParam = > CustomTypeAnnotation("moz_non_param", "non-param"); > > void CustomTypeAnnotation::dumpAnnotationReason(DiagnosticsEngine &Diag, I just remembered. After this patch, this method isn't used anymore, is it? Can you remove it?

(In reply to Michael Layzell [:mystor] from comment #3) > Comment on attachment 8819707 [details] [diff] [review] > Port the muse-use check to the clang-tidy compatible framework > > Review of attachment 8819707 [details] [diff] [review]: > ----------------------------------------------------------------- > > ::: build/clang-plugin/CustomTypeAnnotation.cpp > @@ +18,4 @@ > > CustomTypeAnnotation NonParam = > > CustomTypeAnnotation("moz_non_param", "non-param"); > > > > void CustomTypeAnnotation::dumpAnnotationReason(DiagnosticsEngine &Diag, > > I just remembered. After this patch, this method isn't used anymore, is it? > Can you remove it? Nevermind, you remove it in bug 1324328.

Pushed by eakhgari@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/0da90da58ab7 Port the muse-use check to the clang-tidy compatible framework; r=mystor