Closed
Bug 1326207
Opened 8 years ago
Closed 8 years ago
Remove Django system deploy check awk hack once on Django 1.10
Categories
(Tree Management :: Treeherder, defect)
Tree Management
Treeherder
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: emorley, Assigned: emorley)
References
Details
Attachments
(1 file)
Bug 1247344 has to add a workaround for pre-Django 1.10:
(In reply to Ed Morley [:emorley] from bug 1247344 comment #6)
> I've had to make a slight change from the original PR. Until Django 1.10,
> the check command only exits non-zero if the failures are of ERROR level and
> above. However many of the deployment security checks are WARNING level.
>
> As such, until Django 1.10 (where we can use a newly added `--fail-level`
> option) we have to use awk to override the exit code (works better than grep
> since we want to print the original output and not suppress it).
This workaround doesn't fix the problem entirely, but thankfully we can just remove it and switch to using `--fail-level` once we're on Django 1.10.
|
Assignee | |
Updated•8 years ago
|
Assignee: nobody → emorley
|
||
Comment 1•8 years ago
|
||
|
|
Assignee | |
Updated•8 years ago
|
Attachment #8824494 -
Flags: review?(cdawson)
|
||
Updated•8 years ago
|
Attachment #8824494 -
Flags: review?(cdawson) → review+
|
||
Comment 2•8 years ago
|
||
Commit pushed to master at https://github.com/mozilla/treeherder
https://github.com/mozilla/treeherder/commit/f397b9819ba0499ece4dc84c177dca5907155e5c
Bug 1326207 - Replace Django system check hack with --fail-level
Django 1.10 added a new `--fail-level` option that allows overriding the
default of only exiting 1 for ERROR and above, avoiding the need to rely
on awk hacks:
https://docs.djangoproject.com/en/1.10/ref/django-admin/#check
|
|
Assignee | |
Updated•8 years ago
|
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•