Closed
Bug 1328263
Opened 8 years ago
Closed 8 years ago
Make pushapk-scriptworker tier-2 for Aurora
Categories
(Release Engineering :: General, defect)
Release Engineering
General
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: jlorenzo, Assigned: jlorenzo)
References
Details
Pushapk-scriptworker (sometimes referred as pushapkworker) is a Taskcluster worker which uploads Fennec APKs onto Google Play Store.
Jobs have been running as tier-3 without a major failure[1] for more than one month[2].
Upgrading the tier value has to be done there[3]
[1] That is to say, APKs have always been uploaded without a manual intervention.
[2] https://treeherder.mozilla.org/#/jobs?repo=mozilla-aurora&filter-tier=3&fromchange=7e29173b1641f54d08c60a64cd9d1b5fbc3bba2f&selectedJob=61091636
[3] https://dashboard.heroku.com/apps/fennec-aurora-task-creator/settings => Change the env var TREEHERDER_TIER
From https://wiki.mozilla.org/Sheriffing/Job_Visibility_Policy, the job can't be tier-1 as these criteria are not met:
> Scheduled on every push
Pushapk-scriptworker only acts when a new multi-locale build is done. That is to say, once a day.
> Runs on mozilla-central and all trees that merge into it
mozilla-aurora is only targeted because we don't publish Firefox Nightly on Google Play (yet)
> Easily run on try server
A staging instance of pushapkworker exists, but it hasn't been wired to try.
Assignee | ||
Comment 1•8 years ago
|
||
In regards to the tier-2 criteria, some are not met yet. Would a sheriff help me in answering some questions I left below? They are prefixed with @Sheriffs
* Has an active owner
The releng team, and more specifically myself as the main maintainer.
> Who is committed to ensuring the other requirements are met not just initially, but over the long term.
Check.
> Who will ensure the new job type is switched off to save resources should we stop finding it useful in the future.
Check.
* Usable job logs
> Full logs should be available for both successful and failed runs in either raw or structured formats.
pushapkworker reports full logs back to taskcluster.
> The crash reporter should be enabled, mini-dumps processed correctly (ie: with symbols available) & the resultant valid crash stack visible in the log (it is recommended to use mozcrash to avoid reinventing the wheel).
Not applicable. We don't run or use Firefox.
> Failures must appear in the Treeherder failure summary in order to avoid having to open the full log for every failure.
Not done yet. For instance https://treeherder.mozilla.org/#/jobs?repo=mozilla-aurora&filter-tier=3&fromchange=7e29173b1641f54d08c60a64cd9d1b5fbc3bba2f&selectedJob=59917111. @Sheriffs, would you guys have a pointer to help me bubble up logs?
> Failure output must be in the format expected by the Treeherder's bug suggestion generator (otherwise sheriffs have to manually search Bugzilla when classifying/annotation intermittent failures):
> For non test-specific issues (eg: infra/automation/harness):
> Treeherder falls back to searching Bugzilla for the entire failure line (excluding mozharness logging prefix), so it should be both unique to that failure type & repeatable (ie: no use of process IDs or timestamps, for which there will rarely be a repeat match against a bug summary).
Not done yet, see point above.
> Exceptions & timeouts must be handled with appropriate log output (eg: the failure line must state in which test the timeout occurred, not just that the entire run has timed out).
Not applicable. The script only does one thing.
* Has sufficient documentation
> Has a wiki page with:
The documentation is done on this GitHub README: https://github.com/mozilla-releng/pushapkscript
> An overview of the test-suite.
Not applicable.
> Instructions for running locally.
Detailed in README.
> How to disable an individual failing test.
Not applicable.
> The current owner/who to contact for help.
@Sheriffs: Not explicitly specified, but the project is under the mozilla-releng account. Is it enough to sheriffs?
> The Bugzilla product/component where bugs should be filed (Github issues is not discoverable enough and prevents the use of bug dependencies within the rest of the project).
@Sheriffs: Do we require a bugzilla component for a tier-2 job?
Flags: needinfo?(sheriffs)
Comment 2•8 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=mozilla-aurora&filter-tier=3&filter-searchStr=gp is btw a better link for try
I'm ok with getting this as tier 2 - already talked with Johan about getting a bugzilla component in releng so we can file bugs easier (and for the triaging).
Wes, do you have any concerns ?
Flags: needinfo?(wkocher)
Assignee | ||
Comment 3•8 years ago
|
||
Copying over IRC chats: :catlee pointed out creating a new component won't likely solve the watching issue. :Tomcat and I agreed on using "Release Engineering :: General Automation"
Flags: needinfo?(sheriffs)
Assignee | ||
Comment 4•8 years ago
|
||
> > Failures must appear in the Treeherder failure summary in order to avoid having to
> > open the full log for every failure.
> Not done yet. [...] @Sheriffs, would you guys have a pointer to help me bubble up logs?
Failures summary will be reported back once this PR is merged: https://github.com/mozilla-releng/scriptworker/pull/53
No concerns from me once that PR gets merged.
Flags: needinfo?(wkocher)
Assignee | ||
Comment 6•8 years ago
|
||
PR in comment 4 has been merged. Tc-migration work has also been done. Since then, we've had some successful jobs reporting to Treeherder: https://treeherder.mozilla.org/#/jobs?repo=mozilla-aurora&filter-tier=3&filter-searchStr=gp&fromchange=8dcc2332e280ee23815b44ba76f78c9919d9ebd0
We should now be all set for tier-2.
Then, I set TREEHERDER_TIER to 2 at https://dashboard.heroku.com/apps/fennec-aurora-task-creator.
Assignee | ||
Comment 7•8 years ago
|
||
Job now officially appear as tier-2: https://treeherder.mozilla.org/#/jobs?repo=mozilla-aurora&revision=273f9d9d0feb3ca99c8966e41ec2eb8caefc57ad&filter-searchStr=gp&filter-tier=2
Assignee | ||
Updated•8 years ago
|
Assignee: nobody → jlorenzo
Updated•7 years ago
|
Component: General Automation → General
You need to log in
before you can comment on or make changes to this bug.
Description
•