Closed
Bug 1330673
Opened 8 years ago
Closed 8 years ago
Crash in mozilla::dom::workers::ServiceWorkerManager::LoadRegistration
Categories
(Core :: DOM: Service Workers, defect)
Tracking
()
People
(Reporter: bkelly, Assigned: bkelly)
References
Details
(Keywords: crash)
Crash Data
Attachments
(1 file)
(deleted),
patch
|
baku
:
review+
lizzard
:
approval-mozilla-aurora+
lizzard
:
approval-mozilla-beta+
|
Details | Diff | Splinter Review |
This bug was filed from the Socorro interface and is
report bp-5fe501e7-348d-44d2-bd6e-e51532170111.
=============================================================
I think this might be from trying to use ServiceWorkerManager too early or late when the ServiceWorkerRegistrar does not exist.
Assignee | ||
Updated•8 years ago
|
status-firefox50:
--- → wontfix
status-firefox51:
--- → affected
status-firefox52:
--- → affected
status-firefox53:
--- → affected
status-firefox-esr45:
--- → disabled
Assignee | ||
Comment 1•8 years ago
|
||
There are some low frequency crashes that seem to be due to a nullptr registrar. Presumably this is due to triggering ServiceWorkerManager too early or late. Lets gracefully handle these cases instead of crashing.
Attachment #8826232 -
Flags: review?(amarchesini)
Updated•8 years ago
|
Attachment #8826232 -
Flags: review?(amarchesini) → review+
Pushed by bkelly@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/6bcfde025f6e
Gracefully handle ServiceWorkerRegistrar not being active. r=baku
Assignee | ||
Comment 3•8 years ago
|
||
Comment on attachment 8826232 [details] [diff] [review]
Gracefully handle ServiceWorkerRegistrar not being active. r=baku
Approval Request Comment
[Feature/Bug causing the regression]: Service workers
[User impact if declined]: Low frequency shutdown and startup crashes.
[Is this code covered by automated tests?]: Service workers are heavily tested in automation, but they did not catch this corner case.
[Has the fix been verified in Nightly?]: It has not landed on nightly yet, but requesting a bit early to try to get this in for beta RC next week.
[Needs manual test from QE? If yes, steps to reproduce]: No
[List of other uplifts needed for the feature/fix]: None
[Is the change risky?]: Minimal risk
[Why is the change risky/not risky?]: This basically checks to see if the ServiceWorkerRegistrar service is nullptr before trying to use it. There is very little risk of regression.
[String changes made/needed]:
Attachment #8826232 -
Flags: approval-mozilla-beta?
Attachment #8826232 -
Flags: approval-mozilla-aurora?
Comment on attachment 8826232 [details] [diff] [review]
Gracefully handle ServiceWorkerRegistrar not being active. r=baku
Another crash fix for Service Workers, seems worth the risk for 51 RC.
Attachment #8826232 -
Flags: approval-mozilla-beta?
Attachment #8826232 -
Flags: approval-mozilla-beta+
Attachment #8826232 -
Flags: approval-mozilla-aurora?
Attachment #8826232 -
Flags: approval-mozilla-aurora+
As usual with stuff that hasn't landed yet on m-c -- if it has to get backed out, please note that here so we can either avoid landing it on aurora/beta, or back it out if needed.
Comment 6•8 years ago
|
||
bugherder |
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla53
Assignee | ||
Comment 7•8 years ago
|
||
Assignee | ||
Comment 8•8 years ago
|
||
Assignee | ||
Updated•8 years ago
|
Crash Signature: [@ mozilla::dom::workers::ServiceWorkerManager::LoadRegistration] → [@ mozilla::dom::workers::ServiceWorkerManager::LoadRegistration]
[@ mozilla::dom::workers::ServiceWorkerManager::RegistrationDataPerPrincipal::RegistrationDataPerPrincipal ]
Assignee | ||
Updated•8 years ago
|
Crash Signature: [@ mozilla::dom::workers::ServiceWorkerManager::LoadRegistration]
[@ mozilla::dom::workers::ServiceWorkerManager::RegistrationDataPerPrincipal::RegistrationDataPerPrincipal ] → [@ mozilla::dom::workers::ServiceWorkerManager::LoadRegistration]
[@ mozilla::dom::workers::ServiceWorkerManager::RegistrationDataPerPrincipal::RegistrationDataPerPrincipal ]
[@ mozilla::dom::workers::ServiceWorkerManager::AddScopeAndRegistration ]
Assignee | ||
Updated•8 years ago
|
Crash Signature: [@ mozilla::dom::workers::ServiceWorkerManager::LoadRegistration]
[@ mozilla::dom::workers::ServiceWorkerManager::RegistrationDataPerPrincipal::RegistrationDataPerPrincipal ]
[@ mozilla::dom::workers::ServiceWorkerManager::AddScopeAndRegistration ] → [@ mozilla::dom::workers::ServiceWorkerManager::LoadRegistration]
[@ mozilla::dom::workers::ServiceWorkerManager::RegistrationDataPerPrincipal::RegistrationDataPerPrincipal ]
[@ mozilla::dom::workers::ServiceWorkerManager::AddScopeAndRegistration ]
[@ …
Assignee | ||
Updated•8 years ago
|
Crash Signature: nsTArray_Impl<T>::AssignRange<T> | nsTArray_Impl<T>::AppendElements<T> | mozilla::dom::workers::ServiceWorkerManager::NotifyListenersOnRegister ] → nsTArray_Impl<T>::AssignRange<T> | nsTArray_Impl<T>::AppendElements<T> | mozilla::dom::workers::ServiceWorkerManager::NotifyListenersOnRegister ]
[@ nsTArray_Impl<T>::RemoveElementsAt | mozilla::dom::workers::ServiceWorkerManager::NotifyListenersOnRegis…
You need to log in
before you can comment on or make changes to this bug.
Description
•