Ben Kelly [:bkelly, not reviewing] Assignee
	Description • 8 years ago

This bug was filed from the Socorro interface and is 
report bp-7a547477-bd24-4381-b41a-76c532170111.
=============================================================

This is a crash due to the browser shutting down while we are trying to initialize the ServiceWorkerManager.  We should let shutdown proceed in this case.

	Ben Kelly [:bkelly, not reviewing] Assignee
	Comment 1 • 8 years ago

This forces a ServiceWorkerManager shutdown if the PBackground actor fails to initialize.  The crash-stats stack indicates this can happen in practice when something triggers a ServiceWorkerManager for the first time during browser shutdown.

	Pulsebot
	Comment 2 • 8 years ago

Pushed by bkelly@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/e7da58c2df9a
Don't force crash if ServiceWorkerManager tries to init during browser shutdown. r=baku

	Ben Kelly [:bkelly, not reviewing] Assignee
	Comment 3 • 8 years ago

Comment on attachment 8826238 [details] [diff] [review]
Don't force crash if ServiceWorkerManager tries to init during browser shutdown. r=baku

Approval Request Comment
[Feature/Bug causing the regression]: Service workers
[User impact if declined]: Shutdown crashes
[Is this code covered by automated tests?]: Service workers are heavily tested in automation, but they did not catch this problem.
[Has the fix been verified in Nightly?]: It has landed in mozilla-inbound, but has not merged to nightly yet.
[Needs manual test from QE? If yes, steps to reproduce]: None
[List of other uplifts needed for the feature/fix]: None
[Is the change risky?]: Minimal risk.
[Why is the change risky/not risky?]: This replaces code that did a forced crash if ServiceWorkerManager tried to initialize during shutdown.  This can happen normally, though.  This patch simply uses the existing shutdown logic that was already in place for ServiceWorkerManager objects initialized before shutdown.  It should have minimal risk of regressions.
[String changes made/needed]:

	Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)
	Comment 4 • 8 years ago
bugherder

https://hg.mozilla.org/mozilla-central/rev/e7da58c2df9a

	Liz Henry (:lizzard Please n-i to RyanVM, jcristau, or pascal)
	Comment 5 • 8 years ago

Comment on attachment 8826238 [details] [diff] [review]
Don't force crash if ServiceWorkerManager tries to init during browser shutdown. r=baku

Crash fixes for issues with ServiceWorkers. 
Let's uplift this for the 51 RC build.

	Ryan VanderMeulen [:RyanVM]
	Comment 6 • 8 years ago
bugherder uplift

https://hg.mozilla.org/releases/mozilla-aurora/rev/d4bf0c2182b6

	Ryan VanderMeulen [:RyanVM]
	Comment 7 • 8 years ago
bugherder uplift

https://hg.mozilla.org/releases/mozilla-beta/rev/5581100c4359