Closed
Bug 1330773
Opened 8 years ago
Closed 7 years ago
Rename the fetch-allthethings task to something that mentions runnable jobs
Categories
(Tree Management :: Treeherder: Data Ingestion, defect, P2)
Tree Management
Treeherder: Data Ingestion
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: emorley, Assigned: anejaalisha, Mentored)
References
Details
(Whiteboard: [lang=py])
Attachments
(1 file)
Some of the "fetch all the things" classes/methods have been renamed to ~"runnable jobs", however some remain, making things confusing.
We should rename:
* fetch_allthethings
* AllthethingsTransformerMixin
...etc
|
||
Updated•7 years ago
|
Mentor: cdawson
Whiteboard: [lang=py]
|
Assignee | |
Comment 1•7 years ago
|
||
If this still needs to be resolved, I would like to work on it. Just need a little head start.
|
Reporter | |
Updated•7 years ago
|
Flags: needinfo?(cdawson)
|
|
||
Comment 2•7 years ago
|
||
(In reply to anejaalisha from comment #1)
> If this still needs to be resolved, I would like to work on it. Just need a
> little head start.
I would start by doing a grep/search in the codebase for anything the two strings Ed mentions: fetch_allthethings and AllthethingsTransformerMixin. Rename them to something more like fetch_runnablejobs and RunnableJobsTransformerMixin.
Then make changes to the tests accordingly and make sure they all still run.
Flags: needinfo?(cdawson)
|
||
Comment 3•7 years ago
|
||
|
|
Reporter | |
Comment 4•7 years ago
|
||
I've left some comments on the PR, but this is almost ready to go :-)
Assignee: nobody → anejaalisha
Status: NEW → ASSIGNED
|
|
Reporter | |
Comment 5•7 years ago
|
||
Comment on attachment 8903195 [details]
[treeherder] alisha17:rename_runnable > mozilla:master
This is great - thank you!
Attachment #8903195 -
Flags: review+
|
||
Comment 6•7 years ago
|
||
Commit pushed to master at https://github.com/mozilla/treeherder
https://github.com/mozilla/treeherder/commit/e842ae7701bb1fb2b24fc450443d3a8f064636aa
Bug 1330773 - Use the term 'runnablejobs' rather than 'allthethings' (#2743)
|
|
Reporter | |
Updated•7 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•