Closed
Bug 1331318
Opened 8 years ago
Closed 8 years ago
Add learn more link in the Site Data section
Categories
(Firefox :: Settings UI, defect)
Firefox
Settings UI
Tracking
()
RESOLVED
FIXED
Firefox 53
Tracking | Status | |
---|---|---|
firefox53 | --- | fixed |
People
(Reporter: Fischer, Assigned: Fischer)
References
Details
(Whiteboard: [storage-v1])
Attachments
(1 file)
There should ba a learn more link for the persistent storage in the Site Data section [1]
[1] https://mozilla.invisionapp.com/share/4Y87EJO39#/screens/179637920
Assignee | ||
Updated•8 years ago
|
Comment hidden (mozreview-request) |
Assignee | ||
Comment 2•8 years ago
|
||
mozreview-review |
Comment on attachment 8827056 [details]
Bug 1331318 - Add learn more link in the Site Data section
https://reviewboard.mozilla.org/r/104884/#review105590
::: browser/components/preferences/in-content/advanced.xul:335
(Diff revision 1)
> <groupbox id="siteDataGroup" hidden="true">
> <caption><label>&siteData.label;</label></caption>
>
> <hbox align="center">
> - <label id="totalSiteDataSize" flex="1"></label>
> + <label id="totalSiteDataSize"></label>
> + <label id="siteDataLearnMoreLink" class="learnMore text-link" value="&siteDataLearnMoreLink.label;"></label>
The .learnMore [1] CSS class selector is reused from the bug 1324170.
The bug 1324170 unified the learn more link position in about:preferences.
[1] https://dxr.mozilla.org/mozilla-central/source/browser/themes/shared/incontentprefs/preferences.inc.css#47
Assignee | ||
Comment 3•8 years ago
|
||
Comment on attachment 8827056 [details]
Bug 1331318 - Add learn more link in the Site Data section
Gijs,
This patch adds one learn more link for the persistent storage in the Site Data section [1]
[1] https://mozilla.invisionapp.com/share/4Y87EJO39#/screens/179637920
Thanks
Attachment #8827056 -
Flags: review?(gijskruitbosch+bugs)
Comment 4•8 years ago
|
||
mozreview-review |
Comment on attachment 8827056 [details]
Bug 1331318 - Add learn more link in the Site Data section
https://reviewboard.mozilla.org/r/104886/#review105698
Attachment #8827056 -
Flags: review?(gijskruitbosch+bugs) → review+
Assignee | ||
Comment 5•8 years ago
|
||
TRY: https://treeherder.mozilla.org/#/jobs?repo=try&revision=67d0219405ac0490734147efee32f46baaadc5db
Keywords: checkin-needed
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/66046ad80298
Add learn more link in the Site Data section r=Gijs
Keywords: checkin-needed
Comment 7•8 years ago
|
||
bugherder |
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox53:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 53
Updated•8 years ago
|
QA Whiteboard: [good first verify]
You need to log in
before you can comment on or make changes to this bug.
Description
•