Closed
Bug 1332807
Opened 8 years ago
Closed 8 years ago
fix wrong color scheme and incorrect overlay hover opacity in Window
Categories
(Toolkit :: Video/Audio Controls, defect, P1)
Toolkit
Video/Audio Controls
Tracking
()
RESOLVED
FIXED
mozilla54
Tracking | Status | |
---|---|---|
firefox51 | --- | unaffected |
firefox52 | --- | unaffected |
firefox53 | + | fixed |
firefox54 | --- | verified |
People
(Reporter: ralin, Assigned: ralin)
References
Details
Attachments
(1 file)
(deleted),
text/x-review-board-request
|
jaws
:
review+
ritu
:
approval-mozilla-aurora+
|
Details |
There's two defects in bug 1325591 fix:
1. incorrectly brighten the video while hovering at @comment37
2. inconsistent color scheme @comment34
This should be landed(or uplifted) on 53.
Assignee | ||
Updated•8 years ago
|
status-firefox51:
--- → unaffected
status-firefox52:
--- → unaffected
status-firefox53:
--- → affected
Comment hidden (mozreview-request) |
Assignee | ||
Updated•8 years ago
|
Priority: -- → P1
Comment 3•8 years ago
|
||
mozreview-review |
Comment on attachment 8829295 [details]
Bug 1332807 - Remove overlay opacity when moving mouse over video.
https://reviewboard.mozilla.org/r/106406/#review107546
Attachment #8829295 -
Flags: review?(jaws) → review+
Pushed by jwein@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/dfa424522f2c
Remove overlay opacity when moving mouse over video. r=jaws
This was mentioned by SV as partially blocking "Video Play Visual Refresh" feature. Tracked for 53+
tracking-firefox53:
--- → +
Comment 6•8 years ago
|
||
bugherder |
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
status-firefox54:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla54
Comment 7•8 years ago
|
||
Build ID: 20170124030205
User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:54.0) Gecko/20100101 Firefox/54.0
Tested these issues on Windows 10 x 64, Mac OS X 10.11 and Ubuntu 16.04 x64 on Firefox Nightly 54.0a1 (2017-01-24)(64-bit), and I confirm that they are not reproducible any more.
Comment 8•8 years ago
|
||
Comment on attachment 8829295 [details]
Bug 1332807 - Remove overlay opacity when moving mouse over video.
Approval Request Comment
[Feature/Bug causing the regression]: bug 1325591
[User impact if declined]: white overlay on videos when they're hovered
[Is this code covered by automated tests?]: no
[Has the fix been verified in Nightly?]: yes
[Needs manual test from QE? If yes, steps to reproduce]: already manually tested by QE.
[List of other uplifts needed for the feature/fix]: none
[Is the change risky?]: no
[Why is the change risky/not risky?]: simple CSS removal
[String changes made/needed]: none
Attachment #8829295 -
Flags: approval-mozilla-aurora?
Comment on attachment 8829295 [details]
Bug 1332807 - Remove overlay opacity when moving mouse over video.
CSS only, Aurora53+
Attachment #8829295 -
Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Comment 10•8 years ago
|
||
bugherder uplift |
Comment 11•8 years ago
|
||
Backed out from mozilla-central.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Comment 12•8 years ago
|
||
(In reply to Guilherme Lima from comment #11)
> Backed out from mozilla-central.
This was backed out but it was a result from bug 1325591 which was also backed out, so re-closing as fixed for now.
Status: REOPENED → RESOLVED
Closed: 8 years ago → 8 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•