Closed Bug 133365 Opened 23 years ago Closed 23 years ago

Type letters to navigate XUL listbox

Categories

(Core :: XUL, defect)

defect
Not set
major

Tracking

()

VERIFIED FIXED

People

(Reporter: aaronlev, Assigned: yuanyi21)

Details

(Keywords: access)

Attachments

(1 file, 3 obsolete files)

Spun off from bug 92491, which contains a patch for menus only. assume user press 'A', and: 1. the list has neither shortcut key 'A', nor first letter 'A' -- do nothing 2. the list has only one item which has either shortcut key 'A' or first letter 'A' -- select it and do its action 3. the list has more than one item that has either shortcut key 'A' or first letter 'A' -- go circularly within them but do not act them For condition 3, we should also support incremental typing (IE's Favorities does not support).
Keywords: access
Hardware: Macintosh → All
Summary: Type letters to navigate listbox → Type letters to navigate XUL listbox
Attached patch patch (obsolete) (deleted) — Splinter Review
copy listbox.xml to dist\WIN32_D.OBJ\bin\chrome\toolkit\content\global\bindings (windows) or put it into mozilla/chrome/toolkit.jar (UNIX)
Hi, Jan, Could you review this similar bug?
Attached patch patch (with disableKeyNavigation property) (obsolete) (deleted) — Splinter Review
I tested browser, mailnews, composer, pref, address book. The patch works properly. As far as the autocomplete feature in mail compose, I found that every key typing event is sent to the textbox, so the listbox can not receive any keypress event at all.
Attachment #77184 - Attachment is obsolete: true
Comment on attachment 77791 [details] [diff] [review] patch (with disableKeyNavigation property) r=varga
Attachment #77791 - Flags: review+
Rather than .8 seconds, for the keyboard repeat delay on Windows I think we're supposed to use: GetSystemParametersInfo() SPI_GETKEYBOARDDELAY Get settings for delay time of key inputs.
Attached patch patch (revised according to mpt's comments) (obsolete) (deleted) — Splinter Review
changes: 1. event.charCode >= 32 && event.charCode <= 122 => event.charCode > 0 2. if (event.timeStamp - this._lastKeyTime > 2500) => if (event.timeStamp - this._lastKeyTime > 1000) Jan, can you r= again?
Attachment #77791 - Attachment is obsolete: true
Attachment #78863 - Flags: review+
Comment on attachment 78863 [details] [diff] [review] patch (revised according to mpt's comments) r=varga
um. can i get verification on one thing before you guys do this? are you changing the behavior of mail folderpane so that i can't press n to get my next unread message? Kyle: you just ignored aaronl's comments, SRs: please make sure the patch you sr addresses aaronl's comment 5.
Component: Browser-General → XP Toolkit/Widgets: Trees
QA Contact: doronr → shrir
Timeless, bug 133366 for tree should answer your questions: - That setting I spoke about in comment #5 is for keyboard repeat rate. - Kyle added a new property called disableKeyNavigation to deal with the mail panes
Attachment #78863 - Attachment is obsolete: true
Comment on attachment 80362 [details] [diff] [review] change nothing, just keep the patch up to date. r=varga
Attachment #80362 - Flags: review+
Comment on attachment 80362 [details] [diff] [review] change nothing, just keep the patch up to date. sr=jst
Attachment #80362 - Flags: superreview+
checked into trunk!
Status: NEW → RESOLVED
Closed: 23 years ago
Resolution: --- → FIXED
This change is causing JS exceptions in the mail/news addressingWidgetOverlay. Please see bug 148010.
verif patch is in.
Status: RESOLVED → VERIFIED
Component: XP Toolkit/Widgets: Trees → XUL
QA Contact: shrir → xptoolkit.widgets
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: