Closed Bug 1334329 Opened 8 years ago Closed 8 years ago

Remove migrations made redundant by migration squashing

Categories

(Tree Management :: Treeherder, defect, P3)

defect

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: emorley, Assigned: emorley)

References

Details

Attachments

(1 file)

The next step after bug 1320136. Once enough time has passed for all environments (including Vagrant instances of contributors) to be up to date with the squashed migration, the old migrations files can be deleted. (Doing so too soon will mean people will get errors when running migrate and would have to drop-recreate the DB.) I'd imagine we'd want to wait at least a few weeks. In addition to deleting the old migration files, we'll need to: * Updae all migrations that depend on the deleted migrations to make them depend on the squashed migrations instead. * Remove the `replaces` attribute in the Migration class of the squashed migrations (this is how Django tells that it is a squashed migration).
Assignee: nobody → emorley
Attachment #8841516 - Flags: review?(wlachance)
Comment on attachment 8841516 [details] [treeherder] mozilla:rm-squashed-migrations > mozilla:master Great stuff, thanks!
Attachment #8841516 - Flags: review?(wlachance) → review+
Commits pushed to master at https://github.com/mozilla/treeherder https://github.com/mozilla/treeherder/commit/c860a8035b2d212050e378b82d360e908b5d7564 Bug 1334329 - Remove migrations made redundant by migration squashing It's now been a month since the squashed migrations landed. This cleans up the old unsquashed migrations following the steps here: https://docs.djangoproject.com/en/1.10/topics/migrations/#squashing-migrations If anyone hasn't run migrate locally since, they can either: 1) Update to the parent of this commit and do so first 2) Destroy their vagrant instance and provision from scratch https://github.com/mozilla/treeherder/commit/f91611f6464b877a4bc8dbb39780b786e810c5df Bug 1334329 - Stop ignoring linter errors in migration files Now that we're on Django 1.10 (which doesn't add unused imports) and the old migrations have been removed we no longer need to ignore them and risk hiding real breakage.
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: