Closed
Bug 1334911
Opened 8 years ago
Closed 8 years ago
Asterix * or hash # don't work as a bookmark keyword anymore
Categories
(Firefox :: Address Bar, defect)
Tracking
()
People
(Reporter: mozilla, Unassigned)
References
Details
User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.12; rv:51.0) Gecko/20100101 Firefox/51.0
Build ID: 20170125094131
Steps to reproduce:
I used to have a bookmark to search with Google search. Asterix ('*') was assigned to as a keyword to it to do search like '* <search words>' in location bar. It was working for years in multiple Firefox releases. Unfortunately '*' as a keyword is broken starting version 51. But in general keywords for bookmarks work (I can use 'g' as a keyword, for example).
The bookmark configured:
- Name: Google Web Search
- Location: http://www.google.com/search?q=%s
- Keyword: *
- No descriptions and no tags
Actual results:
Firefox searches with default search for '* <search words>' expression. I.e. it doesn't find match for '*' keyword.
Expected results:
Firefox should navigate to 'http://www.google.com/search?q= <search words>' location.
It's the same issue as bug 1334019.
Blocks: 1306639
Status: UNCONFIRMED → NEW
status-firefox51:
--- → affected
status-firefox52:
--- → affected
status-firefox53:
--- → affected
status-firefox54:
--- → affected
Component: Untriaged → Location Bar
Ever confirmed: true
Flags: needinfo?(mak77)
Keywords: regression
OS: Unspecified → All
Hardware: Unspecified → All
Comment 2•8 years ago
|
||
(In reply to Loic from comment #1)
> It's the same issue as bug 1334019.
I don't think so.
"*" is a reserved char to restrict awesomebar results to only bookmarks, see browser.urlbar.restrict.bookmark in about:config
If you change that restriction char, it's likely you'll be able to use * for a keyword, but I'd rather suggest to rather change the keyword to something else.
Basically the previous behavior was a bug.
Status: NEW → RESOLVED
Closed: 8 years ago
Flags: needinfo?(mak77)
Keywords: regression
Resolution: --- → WONTFIX
The proposed solution doesn't work.
It is hard to consider it as a bug since nothing is documented and prevented a user from entering such a keyword. It was working for years till the moment that was broken in 51 release. Also I presume it was working before with 'browser.urlbar.restrict.bookmark' to to '*'.
And 'change the keyword' is understandable option which is not the best for ones who get used to the specific shortcut. Try to think about changing your shortcut to close tab or window.
Comment 4•8 years ago
|
||
(In reply to pimentium from comment #3)
> The proposed solution doesn't work.
I just tried, and it works for me. I changed the restriction char to something else, and then added a bookmark with an * keyword. "* test" in the urlbar ran the expected search.
Note: I'm on Nightly, not sure if that makes a difference.
> It is hard to consider it as a bug since nothing is documented and prevented
> a user from entering such a keyword. It was working for years till the
> moment that was broken in 51 release. Also I presume it was working before
> with 'browser.urlbar.restrict.bookmark' to to '*'.
Yes, that was wrong, it should have not worked before.
the problem with disallowing certain chars, is that we would need some UI hint to tell the user that value is unacceptable, but the bookmarks dialog is instant-apply, that makes things more complicated. Since this is still an edge case, I feel like the cost to properly blacklist some chars from here is too high to pay (and thus it remains a wontfix).
Summary: Asterix ('*') doesn't work as a bookmark keyword anymore → Asterix * or hash # don't work as a bookmark keyword anymore
You need to log in
before you can comment on or make changes to this bug.
Description
•