Closed
Bug 1335309
Opened 8 years ago
Closed 8 years ago
Make FileFinder's find_executables False by default
Categories
(Firefox Build System :: General, defect)
Firefox Build System
General
Tracking
(firefox54 fixed)
RESOLVED
FIXED
mozilla54
Tracking | Status | |
---|---|---|
firefox54 | --- | fixed |
People
(Reporter: glandium, Assigned: glandium)
References
Details
Attachments
(2 files)
Back when the class was written, for the packaging code, it made sense that the default was True. But now that it's used all over the place, and that the vast majority of uses are with find_executables=False, it makes more sense for that to be the default.
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment 5•8 years ago
|
||
mozreview-review |
Comment on attachment 8831947 [details]
Bug 1335309 - Add explicit find_executables arguments to every use of FileFinder.
https://reviewboard.mozilla.org/r/108418/#review109640
I think this looks good. It's a little hard to verify that for the cases where we switched from the default of True to an explicit False that they don't end up relying on ExecutableFile somewhere, but as you say it looks like that should only be the packager and strip.
Attachment #8831947 -
Flags: review?(mshal) → review+
Comment 6•8 years ago
|
||
mozreview-review |
Comment on attachment 8831948 [details]
Bug 1335309 - Change the default for find_executables to False.
https://reviewboard.mozilla.org/r/108420/#review109642
Attachment #8831948 -
Flags: review?(mshal) → review+
Pushed by mh@glandium.org:
https://hg.mozilla.org/integration/autoland/rev/41b0870f79dc
Add explicit find_executables arguments to every use of FileFinder. r=mshal
https://hg.mozilla.org/integration/autoland/rev/e9ba8f265022
Change the default for find_executables to False. r=mshal
Comment 8•8 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/41b0870f79dc
https://hg.mozilla.org/mozilla-central/rev/e9ba8f265022
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox54:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla54
Updated•7 years ago
|
Product: Core → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•