Closed
Bug 1346381
Opened 8 years ago
Closed 8 years ago
jsshell-linux-x86_64.zip file size grew 7x times
Categories
(Firefox Build System :: General, defect)
Firefox Build System
General
Tracking
(firefox52 unaffected, firefox-esr52 unaffected, firefox53 unaffected, firefox54 fixed, firefox55 fixed)
RESOLVED
FIXED
mozilla55
Tracking | Status | |
---|---|---|
firefox52 | --- | unaffected |
firefox-esr52 | --- | unaffected |
firefox53 | --- | unaffected |
firefox54 | --- | fixed |
firefox55 | --- | fixed |
People
(Reporter: yury, Assigned: glandium)
References
Details
(Keywords: regression)
Attachments
(1 file)
(deleted),
text/x-review-board-request
|
mshal
:
review+
jcristau
:
approval-mozilla-aurora+
|
Details |
At http://ftp.mozilla.org/pub/firefox/nightly/2017/02/2017-02-01-11-00-31-mozilla-central/ file size is 10M
At http://ftp.mozilla.org/pub/firefox/nightly/2017/02/2017-02-02-11-01-08-mozilla-central/ file size is 71M
Looks like binary is not `strip`ed. Is it regression from bug 1335309?
Reporter | ||
Updated•8 years ago
|
Keywords: regression
Reporter | ||
Updated•8 years ago
|
Flags: needinfo?(mh+mozilla)
Comment 1•8 years ago
|
||
This is a major issue for AMO websites as they use jsshell to validate add-on code. We are currently stuck at 52.0.
Comment hidden (mozreview-request) |
Assignee | ||
Updated•8 years ago
|
Assignee: nobody → mh+mozilla
Flags: needinfo?(mh+mozilla)
Comment hidden (mozreview-request) |
Comment 4•8 years ago
|
||
mozreview-review |
Comment on attachment 8847007 [details]
Bug 1346381 - Strip executables in the jsshell package.
https://reviewboard.mozilla.org/r/120052/#review122182
Attachment #8847007 -
Flags: review?(mshal) → review+
Pushed by mh@glandium.org:
https://hg.mozilla.org/integration/autoland/rev/d48202815d98
Strip executables in the jsshell package. r=mshal
Assignee | ||
Comment 6•8 years ago
|
||
Comment on attachment 8847007 [details]
Bug 1346381 - Strip executables in the jsshell package.
Approval Request Comment
[Feature/Bug causing the regression]: Regression from bug 1335309
[User impact if declined]: jsshell package too large
[Is this code covered by automated tests?]: No
[Has the fix been verified in Nightly?]: It has been verified on landing.
[Needs manual test from QE? If yes, steps to reproduce]: Check the size of the jsshell.zip file, before and after.
[List of other uplifts needed for the feature/fix]: N/A
[Is the change risky?]: No
[Why is the change risky/not risky?]: There is no real logic change, just a change in how existing code is called such that it matches what was happening before bug 1335309.
[String changes made/needed]: N/A
Attachment #8847007 -
Flags: approval-mozilla-aurora?
Comment 7•8 years ago
|
||
Comment on attachment 8847007 [details]
Bug 1346381 - Strip executables in the jsshell package.
fix jsshell not being stripped, aurora54+
Attachment #8847007 -
Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Comment 8•8 years ago
|
||
bugherder |
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
Comment 9•8 years ago
|
||
bugherder uplift |
status-firefox54:
--- → fixed
Updated•8 years ago
|
status-firefox52:
--- → unaffected
status-firefox53:
--- → unaffected
status-firefox-esr52:
--- → unaffected
Depends on: 1347750
Updated•7 years ago
|
Product: Core → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•