Closed
Bug 1336270
Opened 8 years ago
Closed 8 years ago
The credentials self-serve page gives an HTTP 500
Categories
(Tree Management :: Treeherder, defect, P1)
Tree Management
Treeherder
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: emorley, Assigned: emorley)
References
Details
Attachments
(1 file)
https://treeherder.allizom.org/credentials/
and
https://treeherder.mozilla.org/credentials/
Give an HTTP 500, due to:
TemplateSyntaxError: Invalid block tag on line 7: 'static'. Did you forget to register or load this tag?
https://papertrailapp.com/systems/treeherder-stage/events?highlight=763963325141901371&focus=763963325141901371&q=program%3Aapp%2Fweb.1
I imagine this will be a regression from the TEMPLATES config changes that had to be made as part of updating to Django 1.10:
https://docs.djangoproject.com/en/1.10/ref/templates/upgrading/
(Even though I followed their guide, sigh)
Assignee | ||
Comment 1•8 years ago
|
||
Ah this is due to a missing `{% load static %}` statement - it was removed in bug 1273034:
https://github.com/mozilla/treeherder/commit/ba8165c23934f65df3bbd809f75af94e77a2a258#diff-305591ed7394d1ff36503ffa74c7b32cL1
Blocks: 1273034
Comment 2•8 years ago
|
||
Assignee | ||
Updated•8 years ago
|
Attachment #8833121 -
Flags: review?(cdawson)
Comment 3•8 years ago
|
||
Comment on attachment 8833121 [details]
[treeherder] mozilla:fix-credentials-self-serve > mozilla:master
Shoot, sorry. My bad. Thanks for fixing this!
Attachment #8833121 -
Flags: review?(cdawson) → review+
Comment 4•8 years ago
|
||
Commit pushed to master at https://github.com/mozilla/treeherder
https://github.com/mozilla/treeherder/commit/ca1d11e0acbd567dddbb69411dc8878987a851c1
Bug 1336270 - Add missing 'load static' to credentials self-serve pages
In order to use the `static` statement later in the file, the static
tag first has to be loaded:
https://docs.djangoproject.com/en/1.10/ref/templates/builtins/#std:templatetag-static
This was previously achieved via `load staticfiles` (deprecated form),
but that was accidentally removed in bug 1273034, resulting in HTTP 500s
when the credentials self-serve pages were accessed.
Assignee | ||
Comment 5•8 years ago
|
||
I've cherrypicked to prod, will be deployed in ~10 mins.
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•