Closed
Bug 1336706
Opened 8 years ago
Closed 8 years ago
when we generate performance alerts, the summary doesn't show e10s for the test
Categories
(Tree Management :: Perfherder, defect)
Tree Management
Perfherder
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: jmaher, Assigned: rwood)
References
Details
Attachments
(1 file, 2 obsolete files)
I have been seeing double alerts for a couple weeks and assumed it was something else. For example I see ts_paint on win8 a couple times but only one change on the graph, looking closer at both alerts, one is e10s and the other is non-e10s (when clicking the 'graph' link).
We need to display this information properly in the alerts dashboard.
Assignee | ||
Updated•8 years ago
|
Assignee: nobody → rwood
Status: NEW → ASSIGNED
Comment 1•8 years ago
|
||
Assignee | ||
Updated•8 years ago
|
Attachment #8833684 -
Flags: review?(jmaher)
Reporter | ||
Comment 2•8 years ago
|
||
Comment on attachment 8833684 [details]
[treeherder] rwood-moz:bug1336706 > mozilla:master
thanks for fixing this so fast!
Attachment #8833684 -
Flags: review?(jmaher) → review+
Comment 3•8 years ago
|
||
Commit pushed to master at https://github.com/mozilla/treeherder
https://github.com/mozilla/treeherder/commit/eb842830b60f04613e9b16dcd6e43dedb9f379c3
Bug 1336706 - Fix performance alert summary (#2135)
Assignee | ||
Updated•8 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Comment 4•8 years ago
|
||
Unfortunately this did not seem to fix the issues. The following alerts are still displaying as non-e10s even though their signature has the e10s property:
https://treeherder.mozilla.org/perf.html#/alerts?id=4988
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Assignee | ||
Updated•8 years ago
|
Attachment #8833684 -
Attachment is obsolete: true
Comment 5•8 years ago
|
||
Assignee | ||
Comment 6•8 years ago
|
||
Comment on attachment 8834624 [details]
[treeherder] rwood-moz:bug1336706-take2 > mozilla:master
I *believe* this should fix it. I haven't tested this on staging yet.
Attachment #8834624 -
Flags: review?(wlachance)
Assignee | ||
Comment 7•8 years ago
|
||
Comment on attachment 8834624 [details]
[treeherder] rwood-moz:bug1336706-take2 > mozilla:master
Tested this out on treeherder-prototype. It fixed the alert titles, the test options were added i.e. 'e10s' to the alert titles. However this patch breaks the graph url titles, the subtest titles, and the e10s dashboard. :( So back to the drawing board.
Attachment #8834624 -
Flags: review?(wlachance)
Assignee | ||
Comment 8•8 years ago
|
||
I've spent several hours on this and can't seem to figure it out, sorry but need some help with this one, thanks!
Flags: needinfo?(wlachance)
Assignee | ||
Updated•8 years ago
|
Attachment #8834624 -
Attachment is obsolete: true
Comment 9•8 years ago
|
||
Assignee | ||
Comment 10•8 years ago
|
||
Comment on attachment 8835025 [details]
[treeherder] mozilla:rwood-moz-bug1336706-take2 > mozilla:master
Thanks for going through the code with me :wlach, appreciated! I have a couple lint errors still to fix but here's the PR
Attachment #8835025 -
Flags: review?(wlachance)
Comment 11•8 years ago
|
||
Comment on attachment 8835025 [details]
[treeherder] mozilla:rwood-moz-bug1336706-take2 > mozilla:master
r+ with linter errors fixed :)
Flags: needinfo?(wlachance)
Attachment #8835025 -
Flags: review?(wlachance) → review+
Assignee | ||
Comment 12•8 years ago
|
||
Comment on attachment 8835025 [details]
[treeherder] mozilla:rwood-moz-bug1336706-take2 > mozilla:master
Messed that pull request up, it is from mozilla: not from my repo
Attachment #8835025 -
Attachment is obsolete: true
Comment 13•8 years ago
|
||
(In reply to Robert Wood [:rwood] from comment #12)
> Messed that pull request up, it is from mozilla: not from my repo
That's not a problem - some of us use own repo, others use the mozilla/treeherder repo as base.
Assignee | ||
Comment 14•8 years ago
|
||
Comment on attachment 8835025 [details]
[treeherder] mozilla:rwood-moz-bug1336706-take2 > mozilla:master
Ok, thanks, will fix the lint errors in this same PR
Attachment #8835025 -
Attachment is obsolete: false
Comment 15•8 years ago
|
||
Commit pushed to master at https://github.com/mozilla/treeherder
https://github.com/mozilla/treeherder/commit/6ca8d8ab6a7b3385a8ccbdcb38819b2784e68ec2
Bug 1336706 - Test options not showing in perf alert titles (#2145)
Assignee | ||
Updated•8 years ago
|
Status: REOPENED → RESOLVED
Closed: 8 years ago → 8 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•