Right now we have them enumerable. Once web platform tests sync this will cause some test failures, for example on url/interfaces.html.

Comment on attachment 8835849 [details] [diff] [review] Make @@iterator properties on DOM prototypes not enumerable, to match IDL spec Review of attachment 8835849 [details] [diff] [review]: ----------------------------------------------------------------- ::: dom/bindings/Codegen.py @@ +3084,1 @@ > # XXX If we ever create non-enumerable properties that can nit: looks like your comment indentation may've gone a bit off here.

> nit: looks like your comment indentation may've gone a bit off here. I don't think it has... that comment applies only to the "else" case of that if/elif/else: the "if" is @@iterator and always non-enumerable, and the "elif" just throws. The "else" case is the only one where interesting enumFlags could happen. I will move the comment to right _before_ we set enumFlags to make that clearer.

Pushed by bzbarsky@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/fcb87a45ab4a Make @@iterator properties on DOM prototypes not enumerable, to match IDL spec. r=qdot