Closed Bug 1339641 Opened 8 years ago Closed 8 years ago

schedule l10n bumper on jamun

Categories

(Release Engineering :: Release Automation: Other, defect)

defect
Not set
normal

Tracking

(firefox54 fixed)

RESOLVED FIXED
Tracking Status
firefox54 --- fixed

People

(Reporter: mozilla, Assigned: mozilla)

References

Details

Attachments

(2 files, 1 obsolete file)

We can point at mozilla-beta when we're ready for fx53b1.
Attachment #8837353 - Flags: review?(rail)
Attached patch schedule on bm77 (obsolete) (deleted) — Splinter Review
Assignee: nobody → aki
Status: NEW → ASSIGNED
Attachment #8837355 - Flags: review?(rail)
Comment on attachment 8837355 [details] [diff] [review] schedule on bm77 Review of attachment 8837355 [details] [diff] [review]: ----------------------------------------------------------------- In overall it looks straight forward. I have some questions below. ::: modules/l10n_bumper/manifests/init.pp @@ +34,5 @@ > + exec { > + # download mozharness > + "download_mozharness": > + require => File["${root}/download_mozharness.sh"], > + command => "${root}/download_mozharness.sh", Hmm... How do we deal with deploying newer versions? Maybe we should explicitly pin the checkout to a particular revision instead of "tip"? At least it'll be reproducible if we decide to move the bumper to another machine. ::: modules/l10n_bumper/manifests/settings.pp @@ +3,5 @@ > + > + $root = "/builds/l10n-bumper" > + $mailto = "aki@mozilla.com" > + $share_base = "/builds/hg-shared" > + $mozharness_repo = "https://hg.mozilla.org/projects/jamun" At some point we'll want to support more than one repos (beta+jamun). Maybe move this to moco-config.pp, something like https://hg.mozilla.org/build/puppet/file/tip/manifests/moco-config.pp#l181 and define the env name per master? @@ +4,5 @@ > + $root = "/builds/l10n-bumper" > + $mailto = "aki@mozilla.com" > + $share_base = "/builds/hg-shared" > + $mozharness_repo = "https://hg.mozilla.org/projects/jamun" > + $mozharness_revision = "tip" Shall we use "default" instead, because "tip" could be moved by Thunderbird release automation, for example.
Attachment #8837353 - Flags: review?(rail) → review+
https://hg.mozilla.org/projects/jamun/rev/92041f45f73ab88d1517c215a1062f16ba0cbcf9 bug 1339641 - have l10n_bumper use curl to avoid old python ssl issues. r=rail
(In reply to Aki Sasaki [:aki] from comment #4) > https://hg.mozilla.org/integration/mozilla-inbound/rev/ > 90b255720b5c3531ec78e42260582cb395996841 > bug 1339641 - update l10n_bumper. r=rail This one addresses the review comments in bug 1337645 and brings the mozilla-inbound copy up to date with the jamun copy. Still working on the puppet patch.
Attached patch puppet-bumper2.diff (deleted) — Splinter Review
Attachment #8837355 - Attachment is obsolete: true
Attachment #8837355 - Flags: review?(rail)
Attachment #8837434 - Flags: review?(rail)
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Comment on attachment 8837434 [details] [diff] [review] puppet-bumper2.diff Review of attachment 8837434 [details] [diff] [review]: ----------------------------------------------------------------- ::: modules/l10n_bumper/manifests/settings.pp @@ +4,5 @@ > + $root = "/builds/l10n-bumper" > + $mailto = "aki@mozilla.com" > + $share_base = "/builds/hg-shared" > + $mozharness_repo = "https://hg.mozilla.org/projects/jamun" > + $mozharness_revision = "tip" Can you remove $mozharness_repo and $mozharness_revision from this file when you land. They are not used from what I see. :shipit:!
Attachment #8837434 - Flags: review?(rail) → review+
landed on puppet, rolled out to bm77, l10n bumper ran successfully. Done!
woot! Thank you!
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: