Closed
Bug 1340276
Opened 8 years ago
Closed 8 years ago
Force wmode=direct for certain Flash applets
Categories
(Core Graveyard :: Plug-ins, defect)
Tracking
(firefox54 fixed)
RESOLVED
FIXED
mozilla54
Tracking | Status | |
---|---|---|
firefox54 | --- | fixed |
People
(Reporter: jimm, Assigned: jimm)
References
Details
Attachments
(1 file, 1 obsolete file)
(deleted),
patch
|
bugzilla
:
review+
|
Details | Diff | Splinter Review |
For applets that:
1) do not specify a wmode value
2) specify wmode=window
this should be behind a new pref, enabled by default in dev channels.
Assignee | ||
Updated•8 years ago
|
Assignee: nobody → jmathies
Assignee | ||
Comment 1•8 years ago
|
||
Assignee | ||
Comment 2•8 years ago
|
||
Attachment #8838249 -
Attachment is obsolete: true
Attachment #8838256 -
Flags: review?(aklotz)
Comment 3•8 years ago
|
||
Comment on attachment 8838256 [details] [diff] [review]
patch
Review of attachment 8838256 [details] [diff] [review]:
-----------------------------------------------------------------
r=me w/ comment either addressed or refuted ;-)
::: dom/plugins/ipc/PluginModuleParent.cpp
@@ +2730,5 @@
> + NS_NAMED_LITERAL_CSTRING(directAttributeValue, "direct");
> + auto wmodeAttributeIndex =
> + names.IndexOf(wmodeAttributeName, 0, comparator);
> + if (wmodeAttributeIndex != names.NoIndex) {
> + if (values[wmodeAttributeIndex].EqualsLiteral("window")) {
Do we need to care about case insensitivity for this comparison?
Attachment #8838256 -
Flags: review?(aklotz) → review+
Assignee | ||
Comment 4•8 years ago
|
||
(In reply to Aaron Klotz [:aklotz] from comment #3)
> Comment on attachment 8838256 [details] [diff] [review]
> patch
>
> Review of attachment 8838256 [details] [diff] [review]:
> -----------------------------------------------------------------
>
> r=me w/ comment either addressed or refuted ;-)
>
> ::: dom/plugins/ipc/PluginModuleParent.cpp
> @@ +2730,5 @@
> > + NS_NAMED_LITERAL_CSTRING(directAttributeValue, "direct");
> > + auto wmodeAttributeIndex =
> > + names.IndexOf(wmodeAttributeName, 0, comparator);
> > + if (wmodeAttributeIndex != names.NoIndex) {
> > + if (values[wmodeAttributeIndex].EqualsLiteral("window")) {
>
> Do we need to care about case insensitivity for this comparison?
There's another check just above this one that does the same case insensitive search, so my guess is yes we want that. These attributes are pulled from content so I'm going to guess that ignoring case is a good idea.
Assignee | ||
Updated•8 years ago
|
Keywords: checkin-needed
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/9f91a792c4f9
Force wmode=direct for certain Flash objects. r=aklotz
Keywords: checkin-needed
Updated•8 years ago
|
Blocks: flash-async-drawing
Assignee | ||
Updated•8 years ago
|
Comment 6•8 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/9f91a792c4f9 - landed 28 hours ago
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla54
Updated•2 years ago
|
Product: Core → Core Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•