Closed Bug 1229961 Opened 9 years ago Closed 9 years ago

Enable direct plugin drawing by default

Categories

(Core Graveyard :: Plug-ins, defect)

Product:
Core Graveyard
Component:
Plug-ins
Version:
40 Branch
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(firefox45 fixed)

Status:
RESOLVED FIXED
Milestone:
mozilla45
Tracking Flags:
Tracking Status
firefox45 --- fixed

People

(Reporter: dvander, Assigned: dvander)

References

Details

(Keywords: site-compat)

Attachments

(2 files)

part 1, telemetry
(deleted), patch
bugzilla
: review+
vladan
: review+
Details | Diff | Splinter Review
part 2, pref flip
(deleted), patch
bugzilla
: review+
Details | Diff | Splinter Review
No description provided.
Attached patch part 1, telemetry (deleted) — — Splinter Review
As part of turning this on, I'd like to have Telemetry on how often each drawing mode gets used. Which is a little tricky, since the drawing mode can change, so I tried to hook the places where we're about to draw something.
Attachment #8695003 - Flags: review?(aklotz)
Comment on attachment 8695003 [details] [diff] [review] part 1, telemetry Vladan for the histogram changes.
Attachment #8695003 - Flags: review?(vladan.bugzilla)
Attached patch part 2, pref flip (deleted) — — Splinter Review
Attachment #8695004 - Flags: review?(aklotz)
Attachment #8695003 - Flags: review?(vladan.bugzilla) → review+
Comment on attachment 8695003 [details] [diff] [review] part 1, telemetry Review of attachment 8695003 [details] [diff] [review]: ----------------------------------------------------------------- ::: toolkit/components/telemetry/Histograms.json @@ +10143,5 @@ > + "alert_emails": ["danderson@mozilla.com"], > + "expires_in_version": "never", > + "kind": "enumerated", > + "bug_numbers": [1229961], > + "n_values": 20, This seems a bit high. Can we drop this to 12 or something?
Attachment #8695003 - Flags: review?(aklotz) → review+
Attachment #8695004 - Flags: review?(aklotz) → review+
https://hg.mozilla.org/mozilla-central/rev/deae83275ac7 https://hg.mozilla.org/mozilla-central/rev/a1bd47d76f71
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
status-firefox45: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla45
Depends on: 1232191
Depends on: 1240220
Depends on: 1276020
Depends on: 1276426
Depends on: 1306698
Depends on: 1311928
Depends on: 1311975
Depends on: 1311985
Depends on: 1311740
Depends on: 1311990
Depends on: 1311374
Depends on: 1311867
Depends on: 1311524
Depends on: 1312043
Depends on: 1312208
We need to find someone who can own fixing these regressions. I suspect David is too busy with the OOP compositor work right now.
Flags: needinfo?(blassey.bugs)
Depends on: 1312242
Depends on: 1312293
Depends on: 1312342
Is it possible to backout this feature to add it later after finding a workaround or fixing all the regressions? Many reports have been filed on BMO/SUMO and it affects popular websites like Facebook or news websites when playing game/videos.
Flags: needinfo?(lhenry)
Depends on: 1309037
Depends on: 1309306
Depends on: 1312369
We're going to discuss this and bug 1307108 today. Thanks Loic!
Flags: needinfo?(lhenry)
Flags: needinfo?(blassey.bugs)
Depends on: 1312648
Depends on: 1312688
Depends on: 1314491
Depends on: 1314467
Depends on: 1314935
Depends on: 1315507
Depends on: 1314499
No longer depends on: 1314499
Depends on: 1321866
Depends on: 1245200
Depends on: 1323403
Depends on: 1290528
Depends on: 1325118
Depends on: 1328039
Depends on: 1328040
Depends on: 1320631
Blocks: 1335733
No longer blocks: 1335733
Depends on: 1335733
Depends on: 1339873
Depends on: 1339875
Depends on: 1340276
Depends on: 1342092
Depends on: 1334415
No longer depends on: 1290528
No longer depends on: 1309037
No longer depends on: 1328040
No longer depends on: flash-async-drawing
No longer depends on: 1312648
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: