This will save us significantly on sampler load on the GPU.

Comment on attachment 8838386 [details] Bug 1340398 - Part 1: Allow SyncObject usage for different devices. https://reviewboard.mozilla.org/r/113324/#review114834

Comment on attachment 8838386 [details] Bug 1340398 - Part 1: Allow SyncObject usage for different devices. https://reviewboard.mozilla.org/r/113324/#review114840 ::: gfx/layers/d3d11/CompositorD3D11.cpp:876 (Diff revision 2) > > SetSamplerForSamplingFilter(texturedEffect->mSamplingFilter); > } > break; > + case EffectTypes::NV12: > + { nit: placement of { isn't consistent with the rest here.

Matt, note it's mistakingly suggesting you reviewed part 1. My reorder confused reviewboard :)

Comment on attachment 8838386 [details] Bug 1340398 - Part 1: Allow SyncObject usage for different devices. https://reviewboard.mozilla.org/r/113324/#review118424 ::: gfx/layers/client/TextureClient.h:107 (Diff revision 4) > public: > MOZ_DECLARE_REFCOUNTED_VIRTUAL_TYPENAME(SyncObject) > virtual ~SyncObject() { } > > - static already_AddRefed<SyncObject> CreateSyncObject(SyncHandle aHandle); > + static already_AddRefed<SyncObject> CreateSyncObject(SyncHandle aHandle, > + void* aNativeData = nullptr); Can we just make this extra parameter #ifdef XP_WIN and then use the real type? static_cast always makes me a little bit sad.

Comment on attachment 8842985 [details] Bug 1340398 - Part 3: Use NV12 format by default. https://reviewboard.mozilla.org/r/116724/#review118436 ::: gfx/layers/D3D11ShareHandleImage.cpp:196 (Diff revision 1) > already_AddRefed<TextureClient> > D3D11RecycleAllocator::CreateOrRecycleClient(gfx::SurfaceFormat aFormat, > const gfx::IntSize& aSize) > { > + TextureAllocationFlags allocFlags = TextureAllocationFlags::ALLOC_DEFAULT; > + if (gfxPrefs::PDMWMFUseSyncTexture()) { This can be called off the main thread, right? Should probably cache the value in case it changes between calls.

Comment on attachment 8842403 [details] Bug 1340398 - Part 2: Support NV12 texture hosts in CompositorD3D11. https://reviewboard.mozilla.org/r/116270/#review118438

Comment on attachment 8842985 [details] Bug 1340398 - Part 3: Use NV12 format by default. https://reviewboard.mozilla.org/r/116724/#review119604 ::: gfx/layers/D3D11ShareHandleImage.cpp:196 (Diff revision 1) > already_AddRefed<TextureClient> > D3D11RecycleAllocator::CreateOrRecycleClient(gfx::SurfaceFormat aFormat, > const gfx::IntSize& aSize) > { > + TextureAllocationFlags allocFlags = TextureAllocationFlags::ALLOC_DEFAULT; > + if (gfxPrefs::PDMWMFUseSyncTexture()) { I'll make this pref none-live.

Pushed by bschouten@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/588942cf8807 Part 1: Allow SyncObject usage for different devices. r=mattwoodrow https://hg.mozilla.org/integration/mozilla-inbound/rev/a8af64e23154 Part 2: Support NV12 texture hosts in CompositorD3D11. r=mattwoodrow https://hg.mozilla.org/integration/mozilla-inbound/rev/7d0a9bb0a642 Part 3: Use NV12 format by default. r=mattwoodrow

I had to back these out for static build failures like https://treeherder.mozilla.org/logviewer.html#?job_id=82256847&repo=mozilla-inbound https://hg.mozilla.org/integration/mozilla-inbound/rev/db74935c78fa

(In reply to Wes Kocher (:KWierso) from comment #16) > I had to back these out for static build failures like > https://treeherder.mozilla.org/logviewer.html#?job_id=82256847&repo=mozilla- > inbound > > https://hg.mozilla.org/integration/mozilla-inbound/rev/db74935c78fa Ugh, I don't even think that's actually wrong, it's just forcing me to make the code uglier. Oh well.

Pushed by bschouten@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/b94a413fe46a Part 1: Allow SyncObject usage for different devices. r=mattwoodrow https://hg.mozilla.org/integration/mozilla-inbound/rev/be80dc74a965 Part 2: Support NV12 texture hosts in CompositorD3D11. r=mattwoodrow https://hg.mozilla.org/integration/mozilla-inbound/rev/0d4603ebe97e Part 3: Use NV12 format by default. r=mattwoodrow

https://hg.mozilla.org/mozilla-central/rev/b94a413fe46a https://hg.mozilla.org/mozilla-central/rev/be80dc74a965 https://hg.mozilla.org/mozilla-central/rev/0d4603ebe97e