Closed
Bug 1345814
Opened 8 years ago
Closed 8 years ago
Firefox hangs when seeking or even playing movies on CNN & MSN websites
Categories
(Core :: Audio/Video: Playback, defect)
Tracking
()
VERIFIED
FIXED
mozilla55
Tracking | Status | |
---|---|---|
firefox-esr45 | --- | unaffected |
firefox52 | --- | unaffected |
firefox-esr52 | --- | unaffected |
firefox53 | --- | unaffected |
firefox54 | --- | unaffected |
firefox55 | + | verified |
People
(Reporter: Virtual, Assigned: bas.schouten)
References
()
Details
(Keywords: nightly-community, regression)
Attachments
(2 files)
[Tracking Requested - why for this release]: Regression
STR:
1. Open this URL - http://edition.cnn.com/2017/03/07/vr/manila-philippines-drug-war/index.html
2. Enjoy the hang
3. If not, start seeking the movie, to get the hang.
"Speedy" Regression window (mozilla-inbound)
Good:
https://hg.mozilla.org/integration/mozilla-inbound/rev/4e90c48f26179dc59150ae002a46666014fd3cbc
Bad:
https://hg.mozilla.org/integration/mozilla-inbound/rev/835425e189a5b19703e4f2202e3d96f9629da41f
Pushlog:
https://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=4e90c48f26179dc59150ae002a46666014fd3cbc&tochange=835425e189a5b19703e4f2202e3d96f9629da41f
Probably caused by:
0d4603ebe97e Bas Schouten — Bug 1340398 - Part 3: Use NV12 format by default. r=mattwoodrow
be80dc74a965 Bas Schouten — Bug 1340398 - Part 2: Support NV12 texture hosts in CompositorD3D11. r=mattwoodrow
b94a413fe46a Bas Schouten — Bug 1340398 - Part 1: Allow SyncObject usage for different devices. r=mattwoodrow
Less likely caused by:
f553a59096ad David Anderson — Enable restarting the GPU process when it dies. (bug 1337131, r=milan)
Flags: needinfo?(bas)
Virtual_ManPL [:Virtual] 🇵🇱 - (please needinfo? me - so I will see your comment/reply/question/etc.)
Reporter
|
||
Updated•8 years ago
|
Version: 54 Branch → 55 Branch
Comment 1•8 years ago
|
||
I also have this happen on some videos at msn.com. I usually get a not responding message in the caption bar. Fx hangs for a little bit while the audio plays. Eventually the video returns.
Comment 2•8 years ago
|
||
I also have this happen on some videos at msn.com. I usually get a not responding message in the caption bar. Fx hangs for a little bit while the audio plays. Eventually the video returns.
Example: http://www.msn.com/en-us/money/personalfinance/which-income-class-are-you-in/ar-AAk13MO?li=BBnb7Kz
Comment 3•8 years ago
|
||
Virtual_ManPL [:Virtual] 🇵🇱 - (please needinfo? me - so I will see your comment/reply/question/etc.)
Reporter
|
||
Updated•8 years ago
|
Has Regression Range: --- → yes
Has STR: --- → yes
status-firefox52:
--- → unaffected
status-firefox53:
--- → unaffected
status-firefox-esr45:
--- → unaffected
status-firefox-esr52:
--- → unaffected
Summary: Firefox hangs when seeking or even playing movies on CNN websites → Firefox hangs when seeking or even playing movies on CNN & MSN websites
Assignee | ||
Comment 5•8 years ago
|
||
Could you try setting the pref: 'media.windows-media-foundation.use-sync-texture' to false, restart and confirm that fixes the issue?
I'm looking into this.
Flags: needinfo?(bas)
Comment 6•8 years ago
|
||
Comment 7•8 years ago
|
||
I didn't have the pref you mentioned so I added it as False. I got messages on the video that the music was playing and something about captions. The video did not play.
There is a similar pref called media.windows-media-foundation.allow-d3d11-dxva. It was true so I set it to false. Seems the videos are playing now. I still need to test more.
Comment 8•8 years ago
|
||
Bas...
Don't know if this is related to whatever busted the videos but using uBlock Origin to block ads and using the EasyList subscription causes videos on MSN to take from 30-45 seconds to play. During that time I get a spinner. When I disable EasyList filters the video plays right away. I never had this before. I posted this problem on the EasyList forum. I'm wondering if whatever the 'bad' patch did is also affecting ad blocking.
Comment 9•8 years ago
|
||
Forget the uBlock thing I mentioned. The cause was another add-on which happens to use webextensions I got from the google store.
Comment 10•8 years ago
|
||
Setting media.windows-media-foundation.allow-d3d11-dxva to false definitely fixes my video problems.
Comment 11•8 years ago
|
||
I'm getting this with today's build on twitter and imgur when there's html5 video.
Setting media.windows-media-foundation.allow-d3d11-dxva to false fixes it.
Assignee | ||
Comment 12•8 years ago
|
||
(In reply to Gary [:streetwolf] from comment #7)
> I didn't have the pref you mentioned so I added it as False. I got messages
> on the video that the music was playing and something about captions. The
> video did not play.
Hrm, did you restart after setting the pref to false?
Assignee | ||
Comment 13•8 years ago
|
||
(In reply to Gary [:streetwolf] from comment #10)
> Setting media.windows-media-foundation.allow-d3d11-dxva to false definitely
> fixes my video problems.
Yeah, that just bypasses all this code :-)
Comment 14•8 years ago
|
||
(In reply to Bas Schouten (:bas.schouten) from comment #12)
> (In reply to Gary [:streetwolf] from comment #7)
> > I didn't have the pref you mentioned so I added it as False. I got messages
> > on the video that the music was playing and something about captions. The
> > video did not play.
>
> Hrm, did you restart after setting the pref to false?
Yes, I restarted Fx.
Assignee | ||
Comment 15•8 years ago
|
||
Hrm, could you post your about:graphics? Everything seems fine on my machine at least on the first two links.
Comment 16•8 years ago
|
||
Here's my complete about:support.
Comment 17•8 years ago
|
||
FYI.... I've tested with a new profile and had the same problems. They happened even quicker. Have you tried to move the slider ahead? This will usually cause Fx to stall. After around 15-30 seconds the video will play. The audio still plays when the video doesn't.
Assignee | ||
Comment 18•8 years ago
|
||
My guess right now is that this is somehow AMD specific. In at least one of the crashes we see another thread blocked on -releasing- the KeyedMutex, needless to say that should never really be an issue, my guess is that it's waiting on an internal D3D11 thread to finish rendering, and that, for some reason isn't happening.
Comment 19•8 years ago
|
||
(In reply to Bas Schouten (:bas.schouten) from comment #18)
> My guess right now is that this is somehow AMD specific. In at least one of
> the crashes we see another thread blocked on -releasing- the KeyedMutex,
> needless to say that should never really be an issue, my guess is that it's
> waiting on an internal D3D11 thread to finish rendering, and that, for some
> reason isn't happening.
Can you reach out to AMD about this?
Assignee | ||
Comment 20•8 years ago
|
||
I actually bet this has to do with Device re-use on AMD, I have a build which I'm almost certain will fix the issue for you, let me give you that for informative reasons, then I'll look into a 'proper' fix.
Comment 21•8 years ago
|
||
(In reply to Bas Schouten (:bas.schouten) from comment #20)
> I actually bet this has to do with Device re-use on AMD, I have a build
> which I'm almost certain will fix the issue for you, let me give you that
> for informative reasons, then I'll look into a 'proper' fix.
Whatever you need from me I'll be happy to do it.
Assignee | ||
Comment 22•8 years ago
|
||
Could you try the build at: https://archive.mozilla.org/pub/firefox/try-builds/bschouten@mozilla.com-bb4dfa94b8287864c5f67cb5bb556f7dcc6fb77e/ (once it's done) with a clean profile? Let me know if that plays smoothly.
Flags: needinfo?(garyshap)
Comment 23•8 years ago
|
||
Will do.
Comment 24•8 years ago
|
||
Tried out your fix from your try-builds link and so far videos that previously had problems now work fine. Waiting for it to make it to inbound.
Thanks Bas.
Comment 25•8 years ago
|
||
Forgot to mention that I set 'media.windows-media-foundation.allow-d3d11-dxva' back to true while testing.
Assignee | ||
Comment 26•8 years ago
|
||
(In reply to Gary [:streetwolf] from comment #25)
> Forgot to mention that I set
> 'media.windows-media-foundation.allow-d3d11-dxva' back to true while testing.
I did say clean profile ;-). But yeah, as long as you made sure it's all set back :-).
Comment 27•8 years ago
|
||
Just tried a new profile and it also works.
Comment hidden (mozreview-request) |
Assignee | ||
Updated•8 years ago
|
Assignee: nobody → bas
Status: NEW → ASSIGNED
Assignee | ||
Comment 29•8 years ago
|
||
(In reply to Gary [:streetwolf] from comment #27)
> Just tried a new profile and it also works.
Thanks! That's good news, I think we'll be okay with this patch then.
Comment 30•8 years ago
|
||
mozreview-review |
Comment on attachment 8846225 [details]
Bug 1345814: Don't use mutices when the decoding device is the compositor device anyway.
https://reviewboard.mozilla.org/r/119322/#review121316
Attachment #8846225 -
Flags: review?(matt.woodrow) → review+
Comment 31•8 years ago
|
||
Pushed by bschouten@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/46090632bad3
Don't use mutices when the decoding device is the compositor device anyway. r=mattwoodrow
Virtual_ManPL [:Virtual] 🇵🇱 - (please needinfo? me - so I will see your comment/reply/question/etc.)
Reporter
|
||
Updated•8 years ago
|
Keywords: nightly-community
Comment 32•8 years ago
|
||
Backout by archaeopteryx@coole-files.de:
https://hg.mozilla.org/integration/mozilla-inbound/rev/533ce084c0d4
Backed out changeset 46090632bad3 for failing reftests on Windows 8 x64 with e10s enabled, e.g. webgl-capturestream-test.html?preserve. r=backout n a CLOSED TREE
Comment 33•8 years ago
|
||
Backed out for failing reftests on Windows 8 x64 with e10s enabled, e.g. webgl-capturestream-test.html?preserve
https://hg.mozilla.org/integration/mozilla-inbound/rev/533ce084c0d46a7529fd9a37ad99db43bfb206b9
Push with failures: https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&revision=46090632bad356411c602147cadedb7822e3152e&filter-resultStatus=testfailed&filter-resultStatus=busted&filter-resultStatus=exception&filter-resultStatus=retry&filter-resultStatus=usercancel&filter-resultStatus=runnable
Failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=83384823&repo=mozilla-inbound
> 06:37:49 INFO - REFTEST TEST-UNEXPECTED-FAIL | file:///C:/slave/test/build/tests/reftest/tests/dom/canvas/test/reftest/webgl-capturestream-test.html?preserve == file:///C:/slave/test/build/tests/reftest/tests/dom/canvas/test/reftest/wrapper.html?green.png | image comparison, max difference: 255, number of differing pixels: 65536
Comment 34•8 years ago
|
||
Pushed by bschouten@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/8afe7f683eaa
Don't use mutices when the decoding device is the compositor device anyway. r=mattwoodrow
Comment 35•8 years ago
|
||
bugherder |
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
Updated•8 years ago
|
Flags: needinfo?(garyshap)
Assignee | ||
Comment 37•8 years ago
|
||
Can you confirm the issue is fixed on a nightly with a fresh profile? This is a top 10 crash so I want to be absolutely sure :).
Flags: needinfo?(garyshap)
Comment 38•8 years ago
|
||
(In reply to Bas Schouten (:bas.schouten) from comment #37)
> Can you confirm the issue is fixed on a nightly with a fresh profile? This
> is a top 10 crash so I want to be absolutely sure :).
Everything looks great. No crashes at all with a new profile. Thanks Bas.
Virtual_ManPL [:Virtual] 🇵🇱 - (please needinfo? me - so I will see your comment/reply/question/etc.)
Reporter
|
||
Comment 39•8 years ago
|
||
Thanks, looks fix, so I'm marking this as VERIFIED.
Virtual_ManPL [:Virtual] 🇵🇱 - (please needinfo? me - so I will see your comment/reply/question/etc.)
Reporter
|
||
Updated•7 years ago
|
QA Contact: Virtual
You need to log in
before you can comment on or make changes to this bug.
Description
•