Closed Bug 1341722 Opened 8 years ago Closed 7 years ago

Enable the extensions.webextensions.themes.enabled preference to ride the trains

Categories

(WebExtensions :: General, defect)

defect
Not set
normal

Tracking

(firefox55 fixed)

RESOLVED FIXED
mozilla55
Tracking Status
firefox55 --- fixed

People

(Reporter: jaws, Assigned: mikedeboer)

References

(Blocks 1 open bug)

Details

(Whiteboard: [themes][triaged])

Attachments

(1 file, 1 obsolete file)

Once we get the dependencies for bug 1330335 fixed then we can enable the API on Nightly / DevEdition.
Whiteboard: [themes, triaged]
Depends on: 1343821
No longer depends on: 1333953
No longer depends on: themingapi-framework
webextensions: --- → ?
webextensions: ? → ---
Assignee: nobody → mwein
Based on the meeting last week, we think this should be on by default and just ride to release and there was enough done to allow this. Is there anything in bug 1330335 that's a blocker?
Keywords: dev-doc-needed
Whiteboard: [themes, triaged] → [themes][triaged]
(In reply to Andy McKay [:andym] from comment #2) > Is there > anything in bug 1330335 that's a blocker? are we not doing bug 1344243? :(
(In reply to Andrew Swan [:aswan] from comment #4) > are we not doing bug 1344243? :( (I added my comment to bug 1344243)
Comment on attachment 8861218 [details] Bug 1341722 - Enable themes by default now that all of its blockers have landed https://reviewboard.mozilla.org/r/133184/#review136160 I'm not ready to remove the pref yet. Let's add it to firefox.js as `true` instead, so that Thunderbird and Seamonkey can still opt-out (by default).
Attachment #8861218 - Flags: review?(mdeboer) → review-
Is this still something we plan on doing for 55?
I'll write the patch today - thanks for the ping!
Flags: needinfo?(mdeboer)
Assignee: mwein → mdeboer
Status: NEW → ASSIGNED
Flags: needinfo?(mdeboer)
Attachment #8861218 - Attachment is obsolete: true
Comment on attachment 8872956 [details] Bug 1341722 - enable WebExtension themes by default on Nightly and Aurora channels. https://reviewboard.mozilla.org/r/144496/#review148538 ::: browser/app/profile/firefox.js:201 (Diff revision 1) > pref("extensions.{972ce4c6-7e08-4474-a285-3208198ce6fd}.description", "chrome://browser/locale/browser.properties"); > > pref("extensions.webextensions.themes.icons.buttons", "back,forward,reload,stop,bookmark_star,bookmark_menu,downloads,home,app_menu,cut,copy,paste,new_window,new_private_window,save_page,print,history,full_screen,find,options,addons,developer,synced_tabs,open_file,sidebars,share_page,subscribe,text_encoding,email_link,forget,pocket"); > +#ifndef RELEASE_OR_BETA > +pref("extensions.webextensions.themes.enabled", true); > +#endif WHy not all channels and let it ride the trains?
Shouldn't the extensions.webextensions.themes.icons.enabled be enabled too? Or is this planned for later?
(In reply to Richard Marti (:Paenglab) from comment #12) > Shouldn't the extensions.webextensions.themes.icons.enabled be enabled too? > Or is this planned for later? Later and it's not even certain whether we'll enable it at all... our UX dept is not at all convinced yet that the feature is a good idea. We'll see in the near future.
Comment on attachment 8872956 [details] Bug 1341722 - enable WebExtension themes by default on Nightly and Aurora channels. https://reviewboard.mozilla.org/r/144496/#review148960 Might want to update bug title too.
Attachment #8872956 - Flags: review?(amckay) → review+
Summary: Enable the extensions.webextensions.themes.enabled preference on Nightly / DevEdition → Enable the extensions.webextensions.themes.enabled preference to ride the trains
Pushed by mdeboer@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/e5b66b34bd7c enable WebExtension themes by default on Nightly and Aurora channels. r=andym
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
Product: Toolkit → WebExtensions
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: