+++ This bug was initially created as a clone of Bug #1344834 +++ In bug 1332651 we landed flake8 initial support to lint Python files in the Telemetry directory, by disabling all the detected problems. This bug is about enabling the E713, "test for membership should be 'not in'": 1) Remove the E713 rule from the .flake8 file in https://dxr.mozilla.org/mozilla-central/source/toolkit/components/telemetry 2) Run "./mach lint -l flake8 toolkit/components/telemetry". 3) Fix the reported problems

Done, tests pass (./mach test). Submitted for review.

Comment on attachment 8846912 [details] Bug 1344836 - Enable flake8 rule E713: "test for membership should be 'not in'". https://reviewboard.mozilla.org/r/119918/#review122654 This looks good, thanks. Let me push that to try to make sure nothing is broken on the telemetry side due to that change.

Comment on attachment 8846912 [details] Bug 1344836 - Enable flake8 rule E713: "test for membership should be 'not in'". https://reviewboard.mozilla.org/r/119918/#review122654 Perfect, thanks!

Comment on attachment 8846912 [details] Bug 1344836 - Enable flake8 rule E713: "test for membership should be 'not in'". https://reviewboard.mozilla.org/r/119918/#review122654 It needs to be rebased. I will do it after we deal with https://reviewboard.mozilla.org/r/119900/

Comment on attachment 8846912 [details] Bug 1344836 - Enable flake8 rule E713: "test for membership should be 'not in'". https://reviewboard.mozilla.org/r/119918/#review122654 Now that the other bug landed, would you please rebase this?

Comment on attachment 8846912 [details] Bug 1344836 - Enable flake8 rule E713: "test for membership should be 'not in'". https://reviewboard.mozilla.org/r/119918/#review122654 Yes, I'm going to do it now...

Pushed by alessio.placitelli@gmail.com: https://hg.mozilla.org/integration/autoland/rev/d5f899fa1771 Enable flake8 rule E713: "test for membership should be 'not in'". r=Dexter