Closed Bug 1344840 Opened 8 years ago Closed 8 years ago

Enable flake8 rule E231: "missing whitespace after ','"

Categories

(Toolkit :: Telemetry, enhancement, P3)

Product:
Toolkit
Component:
Telemetry
Type:
enhancement
Points:
1

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla55
Tracking Flags:
Tracking Status
firefox55 --- fixed

People

(Reporter: Dexter, Assigned: paavininanda, Mentored)

References

Details

(Keywords: good-first-bug, Whiteboard: [measurement:client][lang=python])

Attachments

(1 file, 2 obsolete files)

bug1344840.patch
(deleted), patch
Dexter
: review+
Details | Diff | Splinter Review
+++ This bug was initially created as a clone of Bug #1344836 +++ In bug 1332651 we landed flake8 initial support to lint Python files in the Telemetry directory, by disabling all the detected problems. This bug is about enabling the E231, "missing whitespace after ','": 1) Remove the E231rule from the .flake8 file in https://dxr.mozilla.org/mozilla-central/source/toolkit/components/telemetry 2) Run "./mach lint -l flake8 toolkit/components/telemetry". 3) Fix the reported problems
No longer depends on: 1344836
Blocks: 1344841
No longer blocks: 1344841
Keywords: good-first-bug
Attached patch Added missing whitespaces (obsolete) (deleted) — — Splinter Review
Please assign this to me. Solved the bug.
Attached patch added whitespaces (obsolete) (deleted) — — Splinter Review
Attachment #8846471 - Attachment is obsolete: true
Attachment #8846473 - Flags: review+
Sorry i did review+ by mistake.
Flags: needinfo?(alessio.placitelli)
Assignee: nobody → paavininanda
Flags: needinfo?(alessio.placitelli)
Attachment #8846473 - Flags: review+ → review?(alessio.placitelli)
Attached patch bug1344840.patch (deleted) — — Splinter Review
Attachment #8846473 - Attachment is obsolete: true
Attachment #8846473 - Flags: review?(alessio.placitelli)
Attachment #8846767 - Flags: review?(gfritzsche)
Attachment #8846767 - Flags: review?(gfritzsche) → review?(alessio.placitelli)
Comment on attachment 8846767 [details] [diff] [review] bug1344840.patch Review of attachment 8846767 [details] [diff] [review]: ----------------------------------------------------------------- This looks good, thanks!
Attachment #8846767 - Flags: review?(alessio.placitelli) → review+
Attachment #8846767 - Flags: checkin?
Attachment #8846767 - Flags: checkin?
https://hg.mozilla.org/integration/mozilla-inbound/rev/83eb15651f24e14962ef4033a8544092bc3fa580 Bug 1344840 - Enable flake8 rule E231: "missing whitespace after ','". r=dexter
https://hg.mozilla.org/mozilla-central/rev/83eb15651f24
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox55: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: