+++ This bug was initially created as a clone of Bug #1344840 +++ In bug 1332651 we landed flake8 initial support to lint Python files in the Telemetry directory, by disabling all the detected problems. This bug is about enabling the E111, "indentation is not a multiple of four": 1) Remove the E231rule from the .flake8 file in https://dxr.mozilla.org/mozilla-central/source/toolkit/components/telemetry 2) Run "./mach lint -l flake8 toolkit/components/telemetry". 3) Fix the reported problems

I have fixed this. How do I upload? Just: hg commit .... hg push review or what? Also, I've created a bookmark for just this fix. hg push review is fine or do I need to provide some other option (like -B bookmark_name) to the command? Thanks a lot!

Also, a tiny error in the description of this bug. "Remove the E231rule" should actually be "E111".

I was thinking having this commit message: Bug 1344841 - Enable flake8 rule E111: "indentation is not a multiple of four". r?dexter This patch enables flake8 rule E111: "indentation is not a multiple of four" in toolkit/components/telemetry by removing the relative E111 entry from toolkit/components/telemetry/.flake8 and fixing the files for which the E111 error was reported. Is that ok or I need to remove the "detailed" description and keeping it only one line (Bug....)? Thanks!

(In reply to Federico Padua (fedepad) from comment #1) > I have fixed this. How do I upload? > Just: > hg commit .... > hg push review > > or what? > Also, I've created a bookmark for just this fix. hg push review is fine or > do I need to provide some other option (like -B bookmark_name) to the > command? > > Thanks a lot! Thanks for fixing this! You can just issue "hg push review", it will push the currently active bookmark. Also make sure that the tests are passing before requesting a review ;)

(In reply to Federico Padua (fedepad) from comment #3) > I was thinking having this commit message: > > Bug 1344841 - Enable flake8 rule E111: "indentation is not a multiple of > four". r?dexter > > This patch enables flake8 rule E111: "indentation is not a multiple of four" > in toolkit/components/telemetry by removing the relative E111 entry from > toolkit/components/telemetry/.flake8 and fixing the files for which the E111 > error was reported. > > Is that ok or I need to remove the "detailed" description and keeping it > only one line (Bug....)? > > Thanks! That's perfect! You are encouraged to detail the changes after the first line of the commit message, if deemed appropriate.

Ok, perfect! Last (really) thing: how do I run the tests? Thanks!

I run the tests and I get some fails that I don't think are related to the changes but might be wrong. Here the results: Ran 846 tests Expected results: 755 Unexpected results: 57 (FAIL: 57) Skipped: 34 Unexpected Results ================== FAIL test_window_position.py TestWindowPosition.test_move_to_existing_position FAIL test_accessiblecaret_cursor_mode.py AccessibleCaretCursorModeTestCase.test_caret_not_jump_when_dragging_to_editable_content_boundary_contenteditable FAIL test_accessiblecaret_cursor_mode.py AccessibleCaretCursorModeTestCase.test_caret_not_jump_when_dragging_to_editable_content_boundary_input FAIL test_accessiblecaret_cursor_mode.py AccessibleCaretCursorModeTestCase.test_caret_not_jump_when_dragging_to_editable_content_boundary_input_padding FAIL test_accessiblecaret_cursor_mode.py AccessibleCaretCursorModeTestCase.test_caret_not_jump_when_dragging_to_editable_content_boundary_textarea_one_line FAIL test_accessiblecaret_cursor_mode.py AccessibleCaretCursorModeTestCase.test_drag_caret_from_front_to_end_across_columns FAIL test_accessiblecaret_cursor_mode.py AccessibleCaretCursorModeTestCase.test_move_cursor_to_end_by_dragging_caret_to_bottom_right_corner_textarea FAIL test_accessiblecaret_cursor_mode.py AccessibleCaretCursorModeTestCase.test_move_cursor_to_front_by_dragging_caret_to_front_br_element FAIL test_accessiblecaret_cursor_mode.py AccessibleCaretCursorModeTestCase.test_move_cursor_to_front_by_dragging_caret_to_front_contenteditable FAIL test_accessiblecaret_cursor_mode.py AccessibleCaretCursorModeTestCase.test_move_cursor_to_front_by_dragging_caret_to_front_input FAIL test_accessiblecaret_cursor_mode.py AccessibleCaretCursorModeTestCase.test_move_cursor_to_front_by_dragging_caret_to_front_textarea FAIL test_accessiblecaret_cursor_mode.py AccessibleCaretCursorModeTestCase.test_move_cursor_to_the_right_by_one_character_contenteditable FAIL test_accessiblecaret_cursor_mode.py AccessibleCaretCursorModeTestCase.test_move_cursor_to_the_right_by_one_character_input FAIL test_accessiblecaret_cursor_mode.py AccessibleCaretCursorModeTestCase.test_move_cursor_to_the_right_by_one_character_textarea FAIL test_accessiblecaret_selection_mode.py AccessibleCaretSelectionModeTestCase.test_carets_not_jump_when_dragging_to_editable_content_boundary_contenteditable FAIL test_accessiblecaret_selection_mode.py AccessibleCaretSelectionModeTestCase.test_carets_not_jump_when_dragging_to_editable_content_boundary_input FAIL test_accessiblecaret_selection_mode.py AccessibleCaretSelectionModeTestCase.test_carets_not_jump_when_dragging_to_editable_content_boundary_input_padding FAIL test_accessiblecaret_selection_mode.py AccessibleCaretSelectionModeTestCase.test_carets_not_jump_when_dragging_to_editable_content_boundary_textarea_one_line FAIL test_accessiblecaret_selection_mode.py AccessibleCaretSelectionModeTestCase.test_drag_caret_over_non_selectable_field FAIL test_accessiblecaret_selection_mode.py AccessibleCaretSelectionModeTestCase.test_drag_caret_to_beginning_of_a_line FAIL test_accessiblecaret_selection_mode.py AccessibleCaretSelectionModeTestCase.test_drag_carets_content FAIL test_accessiblecaret_selection_mode.py AccessibleCaretSelectionModeTestCase.test_drag_carets_contenteditable FAIL test_accessiblecaret_selection_mode.py AccessibleCaretSelectionModeTestCase.test_drag_carets_input FAIL test_accessiblecaret_selection_mode.py AccessibleCaretSelectionModeTestCase.test_drag_carets_textarea FAIL test_accessiblecaret_selection_mode.py AccessibleCaretSelectionModeTestCase.test_drag_carets_textarea_rtl FAIL test_accessiblecaret_selection_mode.py AccessibleCaretSelectionModeTestCase.test_drag_swappable_caret_over_non_selectable_field FAIL test_accessiblecaret_selection_mode.py AccessibleCaretSelectionModeTestCase.test_drag_swappable_carets_content FAIL test_accessiblecaret_selection_mode.py AccessibleCaretSelectionModeTestCase.test_drag_swappable_carets_contenteditable FAIL test_accessiblecaret_selection_mode.py AccessibleCaretSelectionModeTestCase.test_drag_swappable_carets_input FAIL test_accessiblecaret_selection_mode.py AccessibleCaretSelectionModeTestCase.test_drag_swappable_carets_textarea FAIL test_accessiblecaret_selection_mode.py AccessibleCaretSelectionModeTestCase.test_drag_swappable_carets_textarea_rtl FAIL test_accessiblecaret_selection_mode.py AccessibleCaretSelectionModeTestCase.test_handle_tilt_when_carets_overlap_each_other_content FAIL test_accessiblecaret_selection_mode.py AccessibleCaretSelectionModeTestCase.test_handle_tilt_when_carets_overlap_each_other_contenteditable FAIL test_accessiblecaret_selection_mode.py AccessibleCaretSelectionModeTestCase.test_handle_tilt_when_carets_overlap_each_other_input FAIL test_accessiblecaret_selection_mode.py AccessibleCaretSelectionModeTestCase.test_handle_tilt_when_carets_overlap_each_other_textarea FAIL test_accessiblecaret_selection_mode.py AccessibleCaretSelectionModeTestCase.test_handle_tilt_when_carets_overlap_each_other_textarea_rtl FAIL test_accessiblecaret_selection_mode.py AccessibleCaretSelectionModeTestCase.test_long_press_changes_focus_from_content_to_contenteditable FAIL test_accessiblecaret_selection_mode.py AccessibleCaretSelectionModeTestCase.test_long_press_changes_focus_from_content_to_input FAIL test_accessiblecaret_selection_mode.py AccessibleCaretSelectionModeTestCase.test_long_press_changes_focus_from_content_to_textarea FAIL test_accessiblecaret_selection_mode.py AccessibleCaretSelectionModeTestCase.test_long_press_changes_focus_from_contenteditable_to_content FAIL test_accessiblecaret_selection_mode.py AccessibleCaretSelectionModeTestCase.test_long_press_changes_focus_from_contenteditable_to_input FAIL test_accessiblecaret_selection_mode.py AccessibleCaretSelectionModeTestCase.test_long_press_changes_focus_from_contenteditable_to_textarea FAIL test_accessiblecaret_selection_mode.py AccessibleCaretSelectionModeTestCase.test_long_press_changes_focus_from_input_to_content FAIL test_accessiblecaret_selection_mode.py AccessibleCaretSelectionModeTestCase.test_long_press_changes_focus_from_input_to_contenteditable FAIL test_accessiblecaret_selection_mode.py AccessibleCaretSelectionModeTestCase.test_long_press_changes_focus_from_input_to_textarea FAIL test_accessiblecaret_selection_mode.py AccessibleCaretSelectionModeTestCase.test_long_press_changes_focus_from_textarea_to_content FAIL test_accessiblecaret_selection_mode.py AccessibleCaretSelectionModeTestCase.test_long_press_changes_focus_from_textarea_to_contenteditable FAIL test_accessiblecaret_selection_mode.py AccessibleCaretSelectionModeTestCase.test_long_press_changes_focus_from_textarea_to_input FAIL test_accessiblecaret_selection_mode.py AccessibleCaretSelectionModeTestCase.test_long_press_to_select_when_partial_visible_word_is_selected FAIL test_accessiblecaret_selection_mode.py AccessibleCaretSelectionModeTestCase.test_minimum_select_one_character2_content2 FAIL test_accessiblecaret_selection_mode.py AccessibleCaretSelectionModeTestCase.test_minimum_select_one_character2_contenteditable2 FAIL test_accessiblecaret_selection_mode.py AccessibleCaretSelectionModeTestCase.test_minimum_select_one_character2_textarea2 FAIL test_accessiblecaret_selection_mode.py AccessibleCaretSelectionModeTestCase.test_minimum_select_one_character_content FAIL test_accessiblecaret_selection_mode.py AccessibleCaretSelectionModeTestCase.test_minimum_select_one_character_contenteditable FAIL test_accessiblecaret_selection_mode.py AccessibleCaretSelectionModeTestCase.test_minimum_select_one_character_input FAIL test_accessiblecaret_selection_mode.py AccessibleCaretSelectionModeTestCase.test_minimum_select_one_character_textarea FAIL test_accessiblecaret_selection_mode.py AccessibleCaretSelectionModeTestCase.test_minimum_select_one_character_textarea_rtl

Can I push for review?

(In reply to Alessio Placitelli [:Dexter] from comment #4) > (In reply to Federico Padua (fedepad) from comment #1) > > I have fixed this. How do I upload? > > Just: > > hg commit .... > > hg push review > > > > or what? > > Also, I've created a bookmark for just this fix. hg push review is fine or > > do I need to provide some other option (like -B bookmark_name) to the > > command? > > > > Thanks a lot! > > Thanks for fixing this! You can just issue "hg push review", it will push > the currently active bookmark. > > Also make sure that the tests are passing before requesting a review ;) Worth mentioning that I run ./mach marionette-test for tests in this case (you see the results below). In other bug fix I run just ./mach test which looks ok...

Comment on attachment 8846836 [details] Bug 1344841 - Enable flake8 rule E111: "indentation is not a multiple of four". https://reviewboard.mozilla.org/r/119830/#review121918 Looks good!

Comment on attachment 8846836 [details] Bug 1344841 - Enable flake8 rule E111: "indentation is not a multiple of four". https://reviewboard.mozilla.org/r/119830/#review121918 Do we need to trigger a try build? If so I don't have the rights to do that so you should trigger it if needed... Thanks!

Pushed by alessio.placitelli@gmail.com: https://hg.mozilla.org/integration/autoland/rev/a6c7a9fcfc29 Enable flake8 rule E111: "indentation is not a multiple of four". r=Dexter

(In reply to Federico Padua (fedepad) from comment #7) > I run the tests and I get some fails that I don't think are related to the > changes but might be wrong. Here the results: > That's unrelated. Marionette and other test suites are not useful to test this changeset, as this only affects linting. The command to test this was mentioned in comment 0. I took it for a manual test ride locally and landed it for you.