Spawn from bug 1309492 comment 15.

From bug 1305338 comment 4: The latest UX spec: https://mozilla.invisionapp.com/share/K48PCVSEM

The upcoming patches are basically from patches-7,8,9,A of Bug 1295921 with the need of the UX spec.

Comment on attachment 8845754 [details] Bug 1346120 part 1 - Extract BlankMediaDataDecoder so it can be shared; https://reviewboard.mozilla.org/r/118904/#review120868 ::: dom/media/platforms/agnostic/BlankDecoderModule.cpp:7 (Diff revision 1) > /* vim:set ts=2 sw=2 sts=2 et cindent: */ > /* This Source Code Form is subject to the terms of the Mozilla Public > * License, v. 2.0. If a copy of the MPL was not distributed with this > * file, You can obtain one at http://mozilla.org/MPL/2.0/. */ > > +#include "DummyMediaDataDecoder.h" The sorting should be case sensitive. Please put paths starting with upper-case characters together.

Comment on attachment 8845755 [details] Bug 1346120 part 2 - Implement NullDecoderModule; https://reviewboard.mozilla.org/r/118906/#review120870

Comment on attachment 8845756 [details] Bug 1346120 part 3 - Use NullDecoderModule while suspending a video element's decoder; https://reviewboard.mozilla.org/r/118908/#review120872

Comment on attachment 8845757 [details] Bug 1346120 part 4 - Only set ImageContainer if there are valid new images in VideoSink::RenderVideoFrames(); https://reviewboard.mozilla.org/r/118910/#review120874 ::: dom/media/mediasink/VideoSink.cpp:404 (Diff revision 1) > > VSINK_LOG_V("playing video frame %" PRId64 " (id=%x) (vq-queued=%" PRIuSIZE ")", > frame->mTime, frame->mFrameID, VideoQueue().GetSize()); > } > + > + if (images.Length()) { Prefer |foo > 0| over |foo| when it comes to integer comparison.

Comment on attachment 8845758 [details] Bug 1346120 part 5 - Revert the blank decoder to create green frames; https://reviewboard.mozilla.org/r/118912/#review120876

Comment on attachment 8845759 [details] Bug 1346120 part 6 - Test drawImage gets a non-single-color image from suspended video; https://reviewboard.mozilla.org/r/118914/#review120878 ::: dom/media/test/test_background_video_drawimage_with_suspended_video.html:50 (Diff revision 1) > + for (let i = 0; i < 4*4; i++) { > + let r = pixels[4*i+0]; > + let g = pixels[4*i+1]; > + let b = pixels[4*i+2]; > + if (r != rr || g != gg || b != bb) { > + allSame = false; Early break when 2 pixels are not the same color.

Try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=1d9ed4f978b1e00d50d5dc26bd4199c215209fe3 https://treeherder.mozilla.org/#/jobs?repo=try&revision=97c46a269379b38139e6a5bdd53443f4958ac993

Try looks pretty good, let's check in, thanks for the review!

Please help to check-in bug 1345403 comment 29 before this bug, sorry for inconvenience and thanks very much!

Pushed by ryanvm@gmail.com: https://hg.mozilla.org/integration/autoland/rev/94a483ef784e part 1 - Extract BlankMediaDataDecoder so it can be shared; r=jwwang https://hg.mozilla.org/integration/autoland/rev/c0758b9bf7b5 part 2 - Implement NullDecoderModule; r=jwwang https://hg.mozilla.org/integration/autoland/rev/ba579adbed21 part 3 - Use NullDecoderModule while suspending a video element's decoder; r=jwwang https://hg.mozilla.org/integration/autoland/rev/98d212462786 part 4 - Only set ImageContainer if there are valid new images in VideoSink::RenderVideoFrames(); r=jwwang https://hg.mozilla.org/integration/autoland/rev/f16556658fd9 part 5 - Revert the blank decoder to create green frames; r=jwwang https://hg.mozilla.org/integration/autoland/rev/a30c73fc8d69 part 6 - Test drawImage gets a non-single-color image from suspended video; r=jwwang

sorry had to back this out for autophone Mdm tests failure in test_background_video_drawimage_with_suspended_video.html like https://treeherder.mozilla.org/logviewer.html#?job_id=83329627&repo=autoland&lineNumber=806 https://hg.mozilla.org/integration/autoland/rev/a7f05a91241e

(In reply to Iris Hsiao [:ihsiao] from comment #31) > sorry had to back this out for autophone Mdm tests failure in > test_background_video_drawimage_with_suspended_video.html like > https://treeherder.mozilla.org/logviewer. > html#?job_id=83329627&repo=autoland&lineNumber=806 > > https://hg.mozilla.org/integration/autoland/rev/a7f05a91241e comment 30 solves this issue.

Try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=2d58ae40ec66d357b9038019b4b0ee541f51cbc1 https://treeherder.mozilla.org/#/jobs?repo=try&revision=4ce13cf27550eabf5e753332ce7e11ac5ed082df

Try looks good, thanks for review and check in again!

Pushed by ryanvm@gmail.com: https://hg.mozilla.org/integration/autoland/rev/f002383e4302 part 1 - Extract BlankMediaDataDecoder so it can be shared; r=jwwang https://hg.mozilla.org/integration/autoland/rev/5e9e7264a224 part 2 - Implement NullDecoderModule; r=jwwang https://hg.mozilla.org/integration/autoland/rev/86e79ca1a6bb part 3 - Use NullDecoderModule while suspending a video element's decoder; r=jwwang https://hg.mozilla.org/integration/autoland/rev/1f5176831c33 part 4 - Only set ImageContainer if there are valid new images in VideoSink::RenderVideoFrames(); r=jwwang https://hg.mozilla.org/integration/autoland/rev/b1ce928cbeeb part 5 - Revert the blank decoder to create green frames; r=jwwang https://hg.mozilla.org/integration/autoland/rev/e924204de040 part 6 - Test drawImage gets a non-single-color image from suspended video; r=jwwang

https://hg.mozilla.org/mozilla-central/rev/f002383e4302 https://hg.mozilla.org/mozilla-central/rev/5e9e7264a224 https://hg.mozilla.org/mozilla-central/rev/86e79ca1a6bb https://hg.mozilla.org/mozilla-central/rev/1f5176831c33 https://hg.mozilla.org/mozilla-central/rev/b1ce928cbeeb https://hg.mozilla.org/mozilla-central/rev/e924204de040