Steps to reproduce: 1) right click on the "Personal Toolbar" 2) click on "New Folder..." in the context menu 3) nothing happens This appears in the JS console: Error: this.getBestItem is not a function Source File: chrome://communicator/content/bookmarks/bookmarksOverlay.js Line: 384

works for me. win98 build 2002032803. please, always add your build id with every bug that you submit.

ops, missed that. buildid: 2002040111

same problem om win32 nigtly mozilla-win32.zip from 01-Apr-2002 11:58 buildid: 2002040103 js console: Error: this.getBestItem is not a function Source File: chrome://communicator/content/bookmarks/bookmarksOverlay.js Line: 384

Confirming on 2002040103 on WinXP. OS -> All

confirm on win2k build 2002041711

I have a fix for this bug. I have a fix for bug 138523, which also fixes this bug. I'm trying to figure out how to check my fix in. I'm having trouble creating a patch diff on Win 2000, any help with that would be appreciated.

*** Bug 135336 has been marked as a duplicate of this bug. ***

have you tried using windiff? Alternatively, download a decent text editor like www.textpad.com which produces document diffs

*** Bug 140872 has been marked as a duplicate of this bug. ***

I posted a fix patch for this bug. See bug 138523.

*** Bug 141185 has been marked as a duplicate of this bug. ***

*** Bug 142761 has been marked as a duplicate of this bug. ***

*** Bug 143495 has been marked as a duplicate of this bug. ***

Looks like a dup of bug 138523 by bug 143962.

This bug appears all over. I've found at least three instances [<A HREF="http://bugzilla.mozilla.org/show_bug.cgi?id=138523" TITLE="Personal Toolbar context menu for the empty area does not work"></A>, <A HREF="http://bugzilla.mozilla.org/show_bug.cgi?id=146692" TITLE="personal toolbar folder doesn't work">bug 146692</A> and <A HREF="http://bugzilla.mozilla.org/show_bug.cgi?id=147249" TITLE="New Folder... menuitem in personal toolbar context menu is broken">bug 147249</A>]. I don't know how to set dup's, but these are all the same - 138523 seems to be the most all-encompassing though. -bZj

*** Bug 150000 has been marked as a duplicate of this bug. ***

*** Bug 147249 has been marked as a duplicate of this bug. ***

To Nav triange team: we should at least remove the non-working UI, doing so should be trivial and safe

this one is a bit worse then just not working. If you have the bookmarks sidebar open and do "New Folder" in the personal toolbar you end up creating the folder at the position currently selected in the sidebar.

Nav triage team: nsbeta1+/adt2

taking

getBestItem is a remnant from bookmarksTree.js This file should be removed (please, please r/rs bug 142236) along with bookmarksDD.js (bug 140414) r/sr, please.

Comment on attachment 93628 [details] [diff] [review] Patch v1.0 sr=blake

Comment on attachment 93628 [details] [diff] [review] Patch v1.0 r=caillon

nominating for the m1.0 branch

Comment on attachment 93628 [details] [diff] [review] Patch v1.0 a=asa (on behalf of drivers) for checkin to 1.1. This will need to land on the 1.1 branch as soon as it is created.

checked in by timeless on trunk and the m1.1final branch

*** Bug 161114 has been marked as a duplicate of this bug. ***

*** Bug 162111 has been marked as a duplicate of this bug. ***

*** Bug 163115 has been marked as a duplicate of this bug. ***

vrfy'd fixed, 2003.02.19 comm trunk builds.