Closed Bug 1347732 Opened 8 years ago Closed 8 years ago

Retriggerable actions don't interpret context correctly

Categories

(Tree Management :: Treeherder, enhancement)

enhancement
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: wlach, Assigned: wlach)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

According to the specification (http://gecko.readthedocs.io/en/latest/taskcluster/taskcluster/action-spec.html#action-kind-task), we should filter out tasks that don't match *any* of the different context options but I'm filtering out those that don't match *every* context option (which is a problem when you have a context like [{'test-type': 'mochitest'}, {'test-type': 'reftest'}])
Blocks: 1322433
Comment on attachment 8847816 [details] [treeherder] wlach:1347732 > mozilla:master Could you have a look at this Brian? I believe this faithfully implements the spec as laid out by Jonas. Certainly things now work for retriggering reftests + mochitests, whereas they didn't before.
Attachment #8847816 - Flags: review?(bstack)
Attachment #8847816 - Flags: review?(bstack) → review+
Commit pushed to master at https://github.com/mozilla/treeherder https://github.com/mozilla/treeherder/commit/584bc84b0cc42166d576006874e0e5d7eb8799da Bug 1347732 - Fix interpretation of "context" for taskcluster actions (#2259)
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: