Closed Bug 1348212 Opened 8 years ago Closed 2 years ago

[Meta] Rework VideoInfo|AudioInfo->mCodecSpecificConfig|mExtraData

Categories

(Core :: Audio/Video: Playback, enhancement, P3)

Product:
Core
Component:
Audio/Video: Playback
Type:
enhancement

Tracking

()

Status:
RESOLVED INCOMPLETE

People

(Reporter: ayang, Assigned: bryce)

References

Details

(Keywords: meta)

This field [1] is added in [2] for b2g only and filled by old b2g demuxer. Since b2g is gone, it should be removed. However, ogg decoder uses it [3], it's worth to check if this field is required or not. [1] https://dxr.mozilla.org/mozilla-central/rev/ff04d410e74b69acfab17ef7e73e7397602d5a68/dom/media/MediaInfo.h#322 [2] https://bugzilla.mozilla.org/show_bug.cgi?id=1153876 [3] http://searchfox.org/mozilla-central/source/dom/media/ogg/OggCodecState.cpp#383
Btw, both AudioInfo and VideoInfo have mExtraData and mCodecSpecificConfig. If we plan to keep it, maybe we should move both fields to TrackInfo and have some nice explanations what they are.

Reviving this. My hope is to merge mExtraData into mCodecSpecificConfig, as I think the latter is the more descriptive naming. Further, my hope is to use a variant, rather than just passing around pointers to binary data.

Assignee: nobody → bvandyk
Summary: Investigate if VideoInfo->mCodecSpecificConfig should be kept → Rework VideoInfo|AudioInfo->mCodecSpecificConfig|mExtraData

Making this meta and will spin off smaller bugs. I'd prefer to do small landings along the way here so we can get finer regression windows if anything goes wrong.

Summary: Rework VideoInfo|AudioInfo->mCodecSpecificConfig|mExtraData → [Meta] Rework VideoInfo|AudioInfo->mCodecSpecificConfig|mExtraData

The meta keyword is there, the bug doesn't depend on other bugs and there is no activity for 12 months.
:bryce, maybe it's time to close this bug?

Flags: needinfo?(bvandyk)

I have some WIP to help with some of this, so there is stuff going on here, it's just not high prio.

Flags: needinfo?(bvandyk)

The meta keyword is there, the bug doesn't depend on other bugs and there is no activity for 12 months.
:jimm, maybe it's time to close this bug?

Flags: needinfo?(jmathies)
Status: NEW → RESOLVED
Closed: 2 years ago
Flags: needinfo?(jmathies)
Resolution: --- → INCOMPLETE
You need to log in before you can comment on or make changes to this bug.