Closed
Bug 1365872
Opened 7 years ago
Closed 7 years ago
Remove b2g codes about parsing mCodecSpecificConfig for mp4v
Categories
(Core :: Audio/Video: Playback, enhancement)
Core
Audio/Video: Playback
Tracking
()
RESOLVED
FIXED
mozilla55
| Tracking | Status | |
|---|---|---|
| firefox55 | --- | fixed |
People
(Reporter: ayang, Assigned: ayang)
References
Details
Attachments
(1 file, 1 obsolete file)
This is from bug 1153876. It can be removed since there is no b2g.
|
Assignee | |
Comment 1•7 years ago
|
||
| Comment hidden (mozreview-request) |
|
|
Assignee | |
Updated•7 years ago
|
Attachment #8868926 -
Attachment is obsolete: true
| Comment hidden (mozreview-request) |
|
||
Comment 4•7 years ago
|
||
| mozreview-review | ||
Comment on attachment 8870313 [details]
Bug 1365872 - remove parsing mp4v mCodecSpecificConfig which is for b2g.
https://reviewboard.mozilla.org/r/141778/#review145372
::: commit-message-baf05:1
(Diff revision 1)
> +Bug 1365872 - remove parsing mp4v mCodecSpecificConfig which is for b2g. r=jya
it would be nice to have both audio and video use the mExtraData field, rather than different name depending of audio or video
::: media/libstagefright/binding/DecoderData.cpp
(Diff revision 1)
>
> FindData(aMetaData, kKeyAVCC, mExtraData);
> - if (!mExtraData->Length()) {
> - if (FindData(aMetaData, kKeyESDS, mExtraData)) {
> - ESDS esds(mExtraData->Elements(), mExtraData->Length());
> -
what about vp9 in mp4 and other codec?
Attachment #8870313 -
Flags: review?(jyavenard) → review+
|
|
Assignee | |
Comment 5•7 years ago
|
||
| mozreview-review | ||
Comment on attachment 8870313 [details]
Bug 1365872 - remove parsing mp4v mCodecSpecificConfig which is for b2g.
https://reviewboard.mozilla.org/r/141778/#review145386
::: media/libstagefright/binding/DecoderData.cpp
(Diff revision 1)
>
> FindData(aMetaData, kKeyAVCC, mExtraData);
> - if (!mExtraData->Length()) {
> - if (FindData(aMetaData, kKeyESDS, mExtraData)) {
> - ESDS esds(mExtraData->Elements(), mExtraData->Length());
> -
I'll file following bugs for that.
Pushed by ayang@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/2edb664cb628
remove parsing mp4v mCodecSpecificConfig which is for b2g. r=jya
|
||
Comment 7•7 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox55:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
|
||
Updated•7 years ago
|
Assignee: nobody → ayang
|
|
Assignee | |
Updated•7 years ago
|
You need to log in
before you can comment on or make changes to this bug.
Description
•