Jared Wein [:jaws] (please needinfo? me) Assignee
	Description • 8 years ago

Follow-up from bug 1343682. We also need to fork the styling that the preferences uses, because we at least will change the icons in bug 1335907.

	Mike Conley (:mconley) (:⚙️)
	Comment 2 • 8 years ago
mozreview-review

Comment on attachment 8850723 [details]
Bug 1350087 - Create a fork of the preferences styling and icons.

https://reviewboard.mozilla.org/r/123252/#review126556

Looks good to me! Maybe consider doing a quick artifact try run to make sure there aren't any testingn gotchas like last time.

::: browser/components/preferences/in-content-old/preferences.xul:8
(Diff revision 1)
>     - License, v. 2.0. If a copy of the MPL was not distributed with this file,
>     - You can obtain one at http://mozilla.org/MPL/2.0/. -->
>  
>  <?xml-stylesheet href="chrome://global/skin/global.css"?>
>  
>  <?xml-stylesheet href="chrome://browser/skin/preferences/preferences.css"?>

Out of curiosity, why do we still have these old preferences.css files lying around?

	Jared Wein [:jaws] (please needinfo? me) Assignee
	Comment 3 • 8 years ago

(In reply to Mike Conley (:mconley) (QF workweek until March 31) from comment #2)
> Comment on attachment 8850723 [details]
> Bug 1350087 - Create a fork of the preferences styling and icons.
> 
> https://reviewboard.mozilla.org/r/123252/#review126556
> 
> Looks good to me! Maybe consider doing a quick artifact try run to make sure
> there aren't any testingn gotchas like last time.

Yes, pushed to tryserver in https://treeherder.mozilla.org/#/jobs?repo=try&revision=f4879ca812de

> ::: browser/components/preferences/in-content-old/preferences.xul:8
> (Diff revision 1)
> >     - License, v. 2.0. If a copy of the MPL was not distributed with this file,
> >     - You can obtain one at http://mozilla.org/MPL/2.0/. -->
> >  
> >  <?xml-stylesheet href="chrome://global/skin/global.css"?>
> >  
> >  <?xml-stylesheet href="chrome://browser/skin/preferences/preferences.css"?>
> 
> Out of curiosity, why do we still have these old preferences.css files lying
> around?

I think these aren't necessary anymore. They look to be a mix of old styles and styles that were added to the wrong place. I'll file a bug to remove them.

	Pulsebot
	Comment 4 • 8 years ago

Pushed by jwein@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/5501750cae57
Create a fork of the preferences styling and icons. r=mconley

	Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)
	Comment 5 • 8 years ago
bugherder

https://hg.mozilla.org/mozilla-central/rev/5501750cae57