The output of the browser_all_files_referenced.js test shows the following lines that seem related to bug 1350087: 42 INFO missing file with code reference: chrome://browser/skin/preferences/in-content-old/search.css 43 INFO missing file with code reference: chrome://browser/skin/preferences/in-content-old/containers.css 44 INFO missing file with code reference: chrome://browser/skin/preferences/in-content-old/favicon.ico 45 INFO missing file with code reference: chrome://browser/locale/preferences-old/applicationManager.properties 56 INFO missing file with code reference: chrome://global/skin/in-content-old/common.css 57 INFO missing file with code reference: chrome://browser/skin/preferences/in-content-old/preferences.css 58 INFO missing file with code reference: chrome://browser/skin/preferences/in-content-old/dialog.css

The reference to chrome://global/skin/in-content-old/common.css is wrong. I'm attaching a patch to change this back to chrome://global/skin/in-content/common.css. The following files are referenced from browser/components/preferences/in-content-old/preferences.xul: chrome://browser/skin/preferences/in-content-old/search.css chrome://browser/skin/preferences/in-content-old/containers.css chrome://browser/skin/preferences/in-content-old/favicon.ico chrome://browser/locale/preferences-old/applicationManager.properties chrome://browser/skin/preferences/in-content-old/preferences.css This last file is referenced from browser/components/preferences/in-content-old/subdialogs.js chrome://browser/skin/preferences/in-content-old/dialog.css

I was wrong above about dialog.css. With this patch applied I no longer see any of these in the output.

Comment on attachment 8853583 [details] Bug 1351999 - Fix references to in-content-old files and create a backup of dialog.css in in-content-old instead of relying on the 'in-content' version to not change. https://reviewboard.mozilla.org/r/125644/#review128512 r- because mach package fails with the following error: 0:19.63 ERROR: The following duplicated files are not allowed: 0:19.63 Nightly.app/Contents/Resources/browser/chrome/browser/skin/classic/browser/preferences/in-content/dialog.css 0:19.63 Nightly.app/Contents/Resources/browser/chrome/browser/skin/classic/browser/preferences/in-content-old/dialog.css I don't really understand why it makes sense to duplicate all these files before their content actually starts differing, but I'll assume you know what you are doing, and will just want to add an exception in allowed-dupes.mn.

(In reply to Florian Quèze [:florian] [:flo] from comment #4) Thank you for catching the installer issue. > I don't really understand why it makes sense to duplicate all these files > before their content actually starts differing, but I'll assume you know > what you are doing, and will just want to add an exception in > allowed-dupes.mn. The "in-content-old" directory will not get as much testing as the default preferences, and it will be very easy to accidentally change a file and not realize that some part of the styling or functionality of "in-content-old" has broken until it may be too late. We will only support the "in-content-old" directory for one "Release" build (57), after which it will be backed out of mozilla-beta58, and mozilla-central59.

Comment on attachment 8853583 [details] Bug 1351999 - Fix references to in-content-old files and create a backup of dialog.css in in-content-old instead of relying on the 'in-content' version to not change. https://reviewboard.mozilla.org/r/125644/#review128596 Okay, thanks for the explanation. (I could have sworn I pressed the "publish" button on this review yesterday; sorry for the delay) ::: browser/themes/linux/jar.mn:78 (Diff revision 2) > skin/classic/browser/places/downloads.png (places/downloads.png) > skin/classic/browser/preferences/alwaysAsk.png (preferences/alwaysAsk.png) > skin/classic/browser/preferences/preferences.css (preferences/preferences.css) > * skin/classic/browser/preferences/in-content-old/preferences.css (preferences/in-content-old/preferences.css) > * skin/classic/browser/preferences/in-content/preferences.css (preferences/in-content/preferences.css) > +* skin/classic/browser/preferences/in-content-old/dialog.css (preferences/in-content-old/dialog.css) nit: I would align this "(preferences/..." with the one on the line before and after, and do this in the 3 jar.mn files you are touching.

Pushed by jwein@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/b35e46dc0604 Fix references to in-content-old files and create a backup of dialog.css in in-content-old instead of relying on the 'in-content' version to not change. r=florian