Closed Bug 1350697 Opened 8 years ago Closed 8 years ago

wasm: Typo in a test

Categories

(Core :: JavaScript Engine, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla55
Tracking Status
firefox55 --- fixed

People

(Reporter: paul.bignier, Assigned: paul.bignier)

References

Details

Attachments

(1 file)

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.12; rv:52.0) Gecko/20100101 Firefox/52.0
Build ID: 20170316213829

Steps to reproduce:

I noticed an error in a .js test file. Not sure how the test suite integration so I'm just pushing a fix
Attached patch Typo fix in JS test (deleted) — Splinter Review
Attachment #8851362 - Flags: review?(bbouvier)
Component: Untriaged → JavaScript Engine
Product: Firefox → Core
Comment on attachment 8851362 [details] [diff] [review]
Typo fix in JS test

Review of attachment 8851362 [details] [diff] [review]:
-----------------------------------------------------------------

Good catch, and long live WebAssemby. Thank you for the patch!
Attachment #8851362 - Flags: review?(bbouvier) → review+
The two issues on this try build were unrelated to this changeset (they were likely caused by bug 1350988). Setting the checkin flag so as to integrate this in our CI.

Thank you for the patch, Paul! If there are any other tasks that are of interest to you, please let us know or feel free to reach us in #jsapi on irc (irc.mozilla.org). Merci !
Assignee: nobody → paul.bignier
Blocks: 1287220
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true
Keywords: checkin-needed
Summary: Typo in a JS test → wasm: Typo in a test
https://hg.mozilla.org/mozilla-central/rev/b5ffe95ba005
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: