Closed
Bug 1350697
Opened 8 years ago
Closed 8 years ago
wasm: Typo in a test
Categories
(Core :: JavaScript Engine, defect)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
mozilla55
Tracking | Status | |
---|---|---|
firefox55 | --- | fixed |
People
(Reporter: paul.bignier, Assigned: paul.bignier)
References
Details
Attachments
(1 file)
(deleted),
patch
|
bbouvier
:
review+
|
Details | Diff | Splinter Review |
User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.12; rv:52.0) Gecko/20100101 Firefox/52.0 Build ID: 20170316213829 Steps to reproduce: I noticed an error in a .js test file. Not sure how the test suite integration so I'm just pushing a fix
Assignee | ||
Comment 1•8 years ago
|
||
Attachment #8851362 -
Flags: review?(bbouvier)
Updated•8 years ago
|
Component: Untriaged → JavaScript Engine
Product: Firefox → Core
Comment 2•8 years ago
|
||
Comment on attachment 8851362 [details] [diff] [review] Typo fix in JS test Review of attachment 8851362 [details] [diff] [review]: ----------------------------------------------------------------- Good catch, and long live WebAssemby. Thank you for the patch!
Attachment #8851362 -
Flags: review?(bbouvier) → review+
Comment 3•8 years ago
|
||
Try build: https://treeherder.mozilla.org/#/jobs?repo=try&revision=8677de267aeabb212b5f8f8f6ef3733d1ab297a1
Comment 4•8 years ago
|
||
The two issues on this try build were unrelated to this changeset (they were likely caused by bug 1350988). Setting the checkin flag so as to integrate this in our CI. Thank you for the patch, Paul! If there are any other tasks that are of interest to you, please let us know or feel free to reach us in #jsapi on irc (irc.mozilla.org). Merci !
Updated•8 years ago
|
Assignee: nobody → paul.bignier
Blocks: 1287220
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true
Keywords: checkin-needed
Summary: Typo in a JS test → wasm: Typo in a test
Pushed by ryanvm@gmail.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/b5ffe95ba005 Typo fix in JS test. r=bbouvier
Keywords: checkin-needed
Comment 6•8 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/b5ffe95ba005
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
status-firefox55:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
You need to log in
before you can comment on or make changes to this bug.
Description
•