Closed
Bug 1350814
Opened 8 years ago
Closed 8 years ago
Replace use of int64_t for microseconds by TimeUnit in AudioSink
Categories
(Core :: Audio/Video: Playback, enhancement, P3)
Core
Audio/Video: Playback
Tracking
()
RESOLVED
FIXED
mozilla55
| Tracking | Status | |
|---|---|---|
| firefox55 | --- | fixed |
People
(Reporter: jwwang, Assigned: jwwang)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
No description provided.
|
Assignee | |
Updated•8 years ago
|
| Comment hidden (mozreview-request) |
|
|
Assignee | |
Updated•8 years ago
|
Attachment #8851855 -
Flags: review?(kikuo)
|
||
Comment 2•8 years ago
|
||
| mozreview-review | ||
Comment on attachment 8851855 [details]
Bug 1350814 - Replace use of int64_t for microseconds by TimeUnit in AudioSink.
https://reviewboard.mozilla.org/r/124062/#review126576
Attachment #8851855 -
Flags: review?(kikuo) → review+
|
|
Assignee | |
Comment 3•8 years ago
|
||
Thanks!
|
||
Comment 4•8 years ago
|
||
We're sorry, Autoland could not rebase your commits for you automatically. Please manually rebase your commits and try again.
hg error in cmd: hg rebase -s 16d7050cd29e -d 4ac559eea9ec: rebasing 385492:16d7050cd29e "Bug 1350814 - Replace use of int64_t for microseconds by TimeUnit in AudioSink. r=kikuo" (tip)
merging dom/media/MediaDecoderStateMachine.cpp
merging dom/media/mediasink/AudioSink.cpp
merging dom/media/mediasink/AudioSinkWrapper.cpp
warning: conflicts while merging dom/media/mediasink/AudioSink.cpp! (edit, then use 'hg resolve --mark')
unresolved conflicts (see hg resolve, then hg rebase --continue)
Pushed by jwwang@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/bf0f89726139
Replace use of int64_t for microseconds by TimeUnit in AudioSink. r=kikuo
|
||
Comment 6•8 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox55:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
|
||
Comment 7•8 years ago
|
||
Unfortunate that all those TimeUnits are passed by value rather than const preferences...
JW, could you open a follow up bug about those?
thanks.
Flags: needinfo?(jwwang)
|
|
Assignee | |
Comment 8•8 years ago
|
||
Do you mean the constructor of AudioSink? Yes I will open a new bug to fix that. Thanks for the reminder.
Flags: needinfo?(jwwang)
You need to log in
before you can comment on or make changes to this bug.
Description
•