Open
Bug 1245019
Opened 9 years ago
Updated 2 years ago
Replace use of int64_t for microseconds by TimeUnit whenever possible
Categories
(Core :: Audio/Video: Playback, defect, P3)
Core
Audio/Video: Playback
Tracking
()
NEW
Tracking | Status | |
---|---|---|
firefox47 | --- | affected |
People
(Reporter: jya, Unassigned)
References
Details
Attachments
(4 files)
(deleted),
patch
|
Details | Diff | Splinter Review | |
(deleted),
patch
|
Details | Diff | Splinter Review | |
(deleted),
patch
|
Details | Diff | Splinter Review | |
(deleted),
patch
|
Details | Diff | Splinter Review |
This bug is to track the replacement of int64_t that is used thorough the media code by TimeUnit objects.
Jean-Yves,
Uploaded the WIP patches I have. I tried to keep each self-contained to aid reviewing. This means that there are places where TimeUnit -> uint64_t -> TimeUnit happens, or TimeUnit -> uint64_t. I have a list of notes of such things to clean up as I saw them, such as:
* WebM - SeekInternal - replace magic with TimeUnit
* WaveReader - Seek - replace magic with TimeUnit
* OggReader - SeekInternal - update to use TimeUnit
* SeekTarget - change mTime from int64 to TimeUnit
* mAudioSeekTimeUs - change to TimeUnit
* mediaData - mTime - change from int64_t to TimeUnit
* MaybeSetChannelStartTime - change TimeUnit
* DecodedAudioDataSink - replace mStartTime
* mCurrentTimeBeforeSeek MDSM.
I don't know any of these are useful. You mentioned that you didn't think all uint64_t should be changed to TimeUnit. Use of TimeUnit certainly helped make clear what units some calculations are in, especially code that converted between seconds, microseconds and nanoseconds.
Flags: needinfo?(jyavenard)
Reporter | ||
Comment 6•9 years ago
|
||
I've done SeekTarget ; overall comment, const SeekTarget& should probably be used whenever possible, prevent a construction + copy.
Can't use references however whenever InvokeAsync is involved.
Flags: needinfo?(jyavenard)
Updated•9 years ago
|
Priority: -- → P2
Mass change P2 -> P3
Priority: P2 → P3
Reporter | ||
Updated•4 years ago
|
Assignee: jya-moz → nobody
Updated•2 years ago
|
Severity: normal → S3
You need to log in
before you can comment on or make changes to this bug.
Description
•