Closed
Bug 1350832
Opened 8 years ago
Closed 8 years ago
Change the type of LOW_AUDIO_USECS to TimeUnit in MDSM
Categories
(Core :: Audio/Video: Playback, enhancement, P3)
Core
Audio/Video: Playback
Tracking
()
RESOLVED
FIXED
mozilla55
| Tracking | Status | |
|---|---|---|
| firefox55 | --- | fixed |
People
(Reporter: jwwang, Assigned: jwwang)
References
(Blocks 1 open bug)
Details
Attachments
(3 files)
No description provided.
|
Assignee | |
Updated•8 years ago
|
| Comment hidden (mozreview-request) |
| Comment hidden (mozreview-request) |
| Comment hidden (mozreview-request) |
|
|
Assignee | |
Updated•8 years ago
|
Attachment #8852302 -
Flags: review?(kikuo)
Attachment #8852303 -
Flags: review?(kikuo)
Attachment #8852304 -
Flags: review?(kikuo)
|
||
Comment 4•8 years ago
|
||
| mozreview-review | ||
Comment on attachment 8852302 [details]
Bug 1350832. P1 - change the type of LOW_AUDIO_USECS to TimeUnit.
https://reviewboard.mozilla.org/r/124548/#review127844
Attachment #8852302 -
Flags: review?(kikuo) → review+
|
|
||
Comment 5•8 years ago
|
||
| mozreview-review | ||
Comment on attachment 8852303 [details]
Bug 1350832. P2 - change the type of mLowAudioThresholdUsecs to TimeUnit.
https://reviewboard.mozilla.org/r/124550/#review127856
Attachment #8852303 -
Flags: review?(kikuo) → review+
|
|
||
Comment 6•8 years ago
|
||
| mozreview-review | ||
Comment on attachment 8852304 [details]
Bug 1350832. P3 - rename variables and fix comments.
https://reviewboard.mozilla.org/r/124552/#review127858
::: dom/media/MediaDecoderStateMachine.h:593
(Diff revision 1)
> - // pause decoding. If we increase mLowAudioThresholdUsecs, we'll also
> - // increase this too appropriately (we don't want mLowAudioThresholdUsecs
> + // pause decoding. If we increase mLowAudioThreshold, we'll also
> + // increase this too appropriately (we don't want mLowAudioThreshold
> // to be greater than ampleAudioThreshold, else we'd stop decoding!).
> // Note that we don't ever reset this threshold, it only ever grows as
> // we detect that the decode can't keep up with rendering.
> int64_t mAmpleAudioThresholdUsecs;
Any plan to file a bug to replace this too ?
Attachment #8852304 -
Flags: review?(kikuo) → review+
|
|
Assignee | |
Comment 7•8 years ago
|
||
| mozreview-review-reply | ||
Comment on attachment 8852304 [details]
Bug 1350832. P3 - rename variables and fix comments.
https://reviewboard.mozilla.org/r/124552/#review127858
> Any plan to file a bug to replace this too ?
Yes. There is bug 1350837. :)
|
|
Assignee | |
Comment 8•8 years ago
|
||
Thanks!
Pushed by jwwang@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/d972b0fcb402
P1 - change the type of LOW_AUDIO_USECS to TimeUnit. r=kikuo
https://hg.mozilla.org/integration/autoland/rev/2533d6d1aa34
P2 - change the type of mLowAudioThresholdUsecs to TimeUnit. r=kikuo
https://hg.mozilla.org/integration/autoland/rev/41344842642b
P3 - rename variables and fix comments. r=kikuo
|
||
Comment 10•8 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/d972b0fcb402
https://hg.mozilla.org/mozilla-central/rev/2533d6d1aa34
https://hg.mozilla.org/mozilla-central/rev/41344842642b
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox55:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
You need to log in
before you can comment on or make changes to this bug.
Description
•