The bookmark button should be split to two separate buttons: a star inside of the URL bar, and a separate button for the "library" outside of the URL bar. When the bookmark star is clicked, there should be an animation of the star as well as an accompanying animation of the library "adding another book". See the attached MP4 for a demonstration of how this should look.

Update to Bookmarking animation based on initial user testing results. Feedback was that users didn't know where to edit after they saved a bookmark. A confirmation/edit door hanger now appears after the user bookmarks. The door hanger will disappear on it's own after a 3 second delay (See updated MP4 for reference).

Updated Bookmarking Animation based on user testing results. Star dropping into library is now triggered after bookmark door hanger is closed

Comment on attachment 8889079 [details] Bug 1352063 - Implement new animation for bookmarking. https://reviewboard.mozilla.org/r/160114/#review165690 This is almost finished, but I'm curious about the pocket reuse question and the breakage for 1374477, and if you have thoughts on that. ::: browser/base/content/browser-places.js:1953 (Diff revision 3) > + if (AppConstants.MOZ_PHOTON_ANIMATIONS) { > + this.star.setAttribute("preloadanimations", "true"); We can remove the listener immediately after this, right? ::: browser/base/content/browser.xul:913 (Diff revision 3) > <image id="reader-mode-button" > class="urlbar-icon" > hidden="true" > onclick="ReaderParent.buttonClick(event);"/> > #ifdef MOZ_PHOTON_THEME > + <hbox id="star-button-box"> This looks like it's set to break with bug 1374477. :-( ::: browser/themes/shared/toolbarbutton-icons.inc.css:488 (Diff revision 3) > + > +#library-button[animate="bookmark"] > .toolbarbutton-icon { > + fill: transparent; > +} > + > +#library-button[animate="bookmark"] > .toolbarbutton-animatable-box { Can't we reuse bits of the pocket-related rules here?

Comment on attachment 8889079 [details] Bug 1352063 - Implement new animation for bookmarking. https://reviewboard.mozilla.org/r/160114/#review165690 > We can remove the listener immediately after this, right? Sure thing. > This looks like it's set to break with bug 1374477. :-( Okay, thanks for the heads up. I will have to find if there are customization events related to the moving of it and add/remove or hide these elements when necessary. > Can't we reuse bits of the pocket-related rules here? I intentionally didn't do this because of the way that Pocket is developed. Since Pocket is a system add-on I believe all of its functionality should be self-contained. If we removed the bookmark-animation I wouldn't want to break Pocket for example.

(In reply to Jared Wein [:jaws] (please needinfo? me) from comment #7) > > This looks like it's set to break with bug 1374477. :-( > > Okay, thanks for the heads up. I will have to find if there are > customization events related to the moving of it and add/remove or hide > these elements when necessary. Ah, this reminds me we will need to hide the element rather than remove it permanently, I think. > > Can't we reuse bits of the pocket-related rules here? > > I intentionally didn't do this because of the way that Pocket is developed. > Since Pocket is a system add-on I believe all of its functionality should be > self-contained. If we removed the bookmark-animation I wouldn't want to > break Pocket for example. Good point.

Comment on attachment 8889079 [details] Bug 1352063 - Implement new animation for bookmarking. https://reviewboard.mozilla.org/r/160114/#review165760

Pushed by jwein@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/9202b42e8dcb Implement new animation for bookmarking. r=Gijs

Backed out for test failures like https://treeherder.mozilla.org/logviewer.html#?job_id=117052604&repo=autoland https://hg.mozilla.org/integration/autoland/rev/310ce703360639bf7e866e0e79b074cc2355e039

Pushed by jwein@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/767224f031ac Implement new animation for bookmarking. r=Gijs

I have seen this "animation for bookmarking" implementation with Latest Nightly 56.0a1 on Windows 8.1 (64 Bit). Build ID : 20170731175927 User Agent : Mozilla/5.0 (Windows NT 6.3; Win64; x64; rv:56.0) Gecko/20100101 Firefox/56.0