Now the the initial switch from Grunt to Neutrino/webpack has landed (bug 1336556), we can work on some follow-ups identified during the review plus UX tweaks now we've had a chance to use it during development. Todo: * Fix usage under Windows (bug 1351907) * Upgrade from Neutrino v4 to the newly released Neutrino v5 (https://github.com/mozilla/treeherder/pull/2309) * Update other packages in package.json * Remove support for the local.conf.js file * Move test dependencies accidentally listed in `dependencies` to `devDependencies` * Move contribute.json into ui/ so special-casing can be removed * Remove local-watch mode in favour of using webpack-dev-server's proxy mode (I've figured out a way to make auth work) * Rename the run-script names to be more intuitive (plus deciding which mode should be default for `start` - using Vagrant's API, stage's or prod's?) * Enable sourcemaps * Use `yarn foo` instead of `yarn run foo` * Clean up SERVICE_DOMAIN usage * File bugs for making eslint config match the standard airbnb one, so we don't need our own * See if minify options and/or BabiliPlugin evaluate=False can be removed, to avoid more Treeherder-specific boilerplate * See if angular partials template hacks can be cleaned up * Try to find ways to speed up the build * File issues against Neutrino for any remaining cases where we've had to add boilerplate for features that may be useful upstream * Fix upstream yarn/npm `--no-bin-links` so fewer hacks required on windows * See if global require()s can be made more specific to reduce build size * See if any libraries can be switched to using ES6 style imports and so benefit from Webpack 2's tree shaking, for reduced build size * See if UI and full stack docs can be merged into one * Make `yarn test` work in the Vagrant environment

Commit pushed to master at https://github.com/mozilla/treeherder https://github.com/mozilla/treeherder/commit/f82f1f5f245e5086d674fa67d4383bdc30c309b9 Bug 1353014 - Move contribute.json to ui/ to simplify build config contribute.json is intended for consumption via the deployed site, so does not need to be in the repo root. Everything in `ui/` will be copied to `dist/` so once moved, `contribute.json` no longer needs to be listed explicitly - and with Neutrino v5 this will allow for even more simplification later.

Commit pushed to master at https://github.com/mozilla/treeherder https://github.com/mozilla/treeherder/commit/bd52f1e75fc3310f965682b1609e16411d51114d Bug 1353014 - Move test/dev package.json dependencies to devDependencies Since they aren't required for the UI build, so don't need to be installed during the Heroku compile (which sets `NODE_ENV=production`).

Eli, I don't suppose you would be able to help with some of the questions on https://github.com/mozilla/treeherder/pull/2309 ? I'm happy to rebase the PR/take it over the line, I just need to understand a few things first :-)

Commits pushed to master at https://github.com/mozilla/treeherder https://github.com/mozilla/treeherder/commit/94d95abe3644525c8a780e6e32a0f5cdfaf202d3 Bug 1353014 - Use double quotes for JSX attribute values Since once we update to Neutrino v5, they will be enforced by the react eslint rules it adds: http://eslint.org/docs/rules/jsx-quotes https://github.com/mozilla/treeherder/commit/549e9b2ba635fdeb826766c28f4d6c205f67d251 Bug 1353014 - Make yarn lint include JSX files too By default eslint only scans for `*.js`: https://github.com/eslint/eslint/issues/8399 Unfortunately it's not possible to set this via a config file: https://github.com/eslint/eslint/issues/3469 https://github.com/mozilla/treeherder/commit/44e23577694c3448e5dec9b19f0566f623986a84 Bug 1353014 - Whitespace cleanup in neutrino-custom.js https://github.com/mozilla/treeherder/commit/27dbf288d52d54bbc254ce365f6a45ee73cc9283 Bug 1353014 - Add {yarn,npm}-error.log to .gitignore

@emorley I'll pick this back up soon, just wrapping up some other things. Thanks for keeping an eye on this.

> Todo: See if the forked and vendored angular-clipboard (see bug 1298086) can be removed in favour of the original package (https://www.npmjs.com/package/angular-clipboard).

(In reply to Ed Morley [:emorley] from comment #5) > Eli, I don't suppose you would be able to help with some of the questions on > https://github.com/mozilla/treeherder/pull/2309 ? > > I'm happy to rebase the PR/take it over the line, I just need to understand > a few things first :-) (In reply to :Eli Perelman from comment #8) > @emorley I'll pick this back up soon, just wrapping up some other things. > Thanks for keeping an eye on this. I've broken out the upgrade to bug 1364894.

I've just unset the environment variable SERVE_MINIFIED_UI on prototype/stage/prod, since it's unused after bug 1336556.

(In reply to Ed Morley [:emorley] from comment #0) > Todo: Make webpack-dev-server (yarn start etc) use polling watch mode when run inside Vagrant, or at least mention that watching won't work inside it as it. See: https://webpack.js.org/guides/development-vagrant/#running-the-server https://webpack.js.org/configuration/dev-server/#devserver-watchoptions- https://webpack.js.org/configuration/watch/#watchoptions-poll

The remaining work here is being tracked in bug 1364894 and other deps.